Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logviewer does not remove it's preference store PropertyChangeListener #61

Closed
GoogleCodeExporter opened this issue Apr 14, 2015 · 5 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1.Open the log viewer
2.Close the log viewer
3.Open the log viewer
4.Change Font settings

What is the expected output? What do you see instead?
After changing the settings, i get the attached exception

I suggest to remove the PropertyChangeListener on disposal of a LogViewer 
instance:
@Override
public void dispose() {
   viewer.removeListeners();  // new method
   storeAllCurrentlyOpenFiles();
   super.dispose();
}

The new method in LogFileViewer looks like: 
public void removeListeners() {
   if (propertyChangeListener != null) {
      store.removePropertyChangeListener(propertyChangeListener);
   }
}


Original issue reported on code.google.com by matthias...@gmail.com on 24 Aug 2011 at 12:17

Attachments:

@GoogleCodeExporter
Copy link
Author

Yes, i see the problem. I will add your patch for next release. Thanks!

Original comment by andre.bo...@gmail.com on 24 Aug 2011 at 5:29

  • Changed state: Accepted
  • Added labels: Milestone-Release-Candidate-0.9.9, OpSys-All

@GoogleCodeExporter
Copy link
Author

Original comment by andre.bo...@anbos.de on 29 Sep 2012 at 7:05

@GoogleCodeExporter
Copy link
Author

Original comment by andre.bo...@anbos.de on 16 Jan 2013 at 8:51

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Original comment by andre.bo...@anbos.de on 20 Sep 2013 at 5:18

  • Added labels: Milestone-Release1.0
  • Removed labels: Milestone-Release-Candidate-0.9.9

@anb0s anb0s added the bug label Sep 25, 2015
@anb0s anb0s added this to the v0.9.9 milestone Sep 25, 2015
anb0s added a commit that referenced this issue Sep 25, 2015
Signed-off-by: Andre Bossert <anb0s@anbos.de>
@anb0s
Copy link
Owner

anb0s commented Sep 25, 2015

Thanks, fixed!

@anb0s anb0s closed this as completed Sep 25, 2015
@anb0s anb0s modified the milestones: v0.9.9, v0.9.8 Jan 10, 2018
@anb0s anb0s modified the milestones: v0.9.8, v0.9.9 Jan 21, 2018
anb0s added a commit that referenced this issue Jan 21, 2018
new fixed issues in this build:
- [x] #61 Logviewer does not remove it's preference store
PropertyChangeListener
- [x] #65 Unable to Open Console in LogViewer
- [x] #76 Failed to open Log Viewer from console: unable to load
resource ProcessConsole\JettyApp [Java Application] ...
- [x] #80 Server returned lastModified <= 0
- [x] #83 Eclipse Mars: cannot locate the resource
- [x] #85 migration to GitHub

Signed-off-by: Andre Bossert <anb0s@anbos.de>
anb0s added a commit that referenced this issue Jan 21, 2018
new fixed issues in this build:
- [x] #61 Logviewer does not remove it's preference store
PropertyChangeListener
- [x] #65 Unable to Open Console in LogViewer
- [x] #76 Failed to open Log Viewer from console: unable to load
resource ProcessConsole\JettyApp [Java Application] ...
- [x] #80 Server returned lastModified <= 0
- [x] #83 Eclipse Mars: cannot locate the resource
- [x] #85 migration to GitHub

Signed-off-by: Andre Bossert <anb0s@anbos.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants