Add basic namespace check on publishing DBs #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
willmurphyscode
approved these changes
Nov 2, 2023
willmurphyscode
pushed a commit
that referenced
this pull request
Mar 27, 2024
Bumps [types-requests](https://github.com/python/typeshed) from 2.30.0.0 to 2.31.0.0. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-requests dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #178
This is an addition to the validation of the DBs being published to ensure they have the minimum expected namespaces based on the current snapshot of namespaces that vunnel provides.
This is not an ideal implementation, since it hard codes the list of namespaces for each supported schema (4-5, 1-3) and this is already captured for schemas 4-5 with https://github.com/anchore/vunnel/blob/main/tests/quality/config.yaml . The hard part about using this is we need to know the specific vunnel version used to be able to reference the correct yaml file (which, also unfortunately, means this would need to be an online operation). If the vunnel could output at least some of this information that would make a better long term path here.
This PR is not about the long term path, but something we could add today that verifies we're not publishing sub-standard databases.