chore(deps): remove dependency on sqlite fork; bump gorm.io/gorm from 1.23.10 to 1.25.4 #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
force-pushed
the
dependabot/go_modules/gorm.io/gorm-1.25.4
branch
from
0ebdf03
to
0bd2e77
Compare
dependabot
bot
force-pushed
the
dependabot/go_modules/gorm.io/gorm-1.25.4
branch
6 times, most recently
from
b942d4c
to
630925a
Compare
Bumps [gorm.io/gorm](https://github.com/go-gorm/gorm) from 1.23.10 to 1.25.4. - [Release notes](https://github.com/go-gorm/gorm/releases) - [Commits](go-gorm/gorm@v1.23.10...v1.25.4) --- updated-dependencies: - dependency-name: gorm.io/gorm dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/gorm.io/gorm-1.25.4
branch
from
630925a
to
c8494c0
Compare
|
I think this is failing because we're depending on an outdated fork of sqlite for go: https://github.com/anchore/sqlite Pulling in latest from https://github.com/go-gorm/sqlite fixes these dependency errors. We should investigate whether we still need this fork. |
The reason we needed to depend on the fork seems no longer to be true. Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Otherwise the driver gets double-registered, which is not allowed. Signed-off-by: Will Murphy <will.murphy@anchore.com>
wagoodman
reviewed
Sep 18, 2023
| @@ -4,14 +4,14 @@ import ( | |||
| "fmt" | |||
| "sort" | |||
|
|
|||
| _ "github.com/glebarez/sqlite" // provide the sqlite dialect to gorm via import | |||
There was a problem hiding this comment.
not a comment for this PR: we should remove these statements and push these side-effect imports to the main package exclusively (as not to pollute the sql driver registration space for lib consumers).
wagoodman
approved these changes
Sep 18, 2023
willmurphyscode
changed the title
willmurphyscode
deleted the
dependabot/go_modules/gorm.io/gorm-1.25.4
branch
robszumski
pushed a commit
to robszumski/grype
that referenced
this pull request
Sep 18, 2023
… 1.23.10 to 1.25.4 (anchore#1448) * chore: remove dependency on sqlite fork * chore(deps): bump gorm.io/gorm from 1.23.10 to 1.25.4 Removed the dependency on github.com/anchore/sqlite because the diff added to that fork was no longer needed. Bumps [gorm.io/gorm](https://github.com/go-gorm/gorm) from 1.23.10 to 1.25.4. - [Release notes](https://github.com/go-gorm/gorm/releases) - [Commits](go-gorm/gorm@v1.23.10...v1.25.4) --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Will Murphy <will.murphy@anchore.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Will Murphy <will.murphy@anchore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps gorm.io/gorm from 1.23.10 to 1.25.4.
Commits
7e44f73fix schema GetIdentityFieldValuesMap interface or ptr (#6417)2c20897add float32 test case (#6530)fef4294feat: rm GetDBConnWithContext method (#6535)bae684bfix(clause): when the value of clause.Eq is an empty array, the SQL should be...15162afSupport GetDBConnWithContext PreparedStmtDB3c34bc2refactor: Regex description (#6507)f473761fix: addedSkipHooksin dbgetInstance()(#6484)193c454keep float precision in ExplainSQL (#6495)1fb26actest: coverage for tabletype added (#6496)a7f01bdTest Pluck with customized typeMost Recent Ignore Conditions Applied to This Pull Request
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)