chore: Update go declaration to have point version #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our understanding is that without the patch version, every run of "go mod tidy" will write a toolchain directive in the file, which will result in a diff from contributors with different point versions of go, which is noisy and prone to breaking CI. Signed-off-by: Will Murphy <will.murphy@anchore.com>
willmurphyscode
added
the
changelog-ignore
willmurphyscode
changed the title
wagoodman
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our understanding is that without the patch version, every run of "go mod tidy" will write a toolchain directive in the file, which will result in a diff from contributors with different point versions of go, which is noisy and prone to breaking CI.
Thanks to golang/go#62278 (comment) for the concise explanation of what seems to be going on with the changes to go.mod.