-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: mod tidy reports toolchain not available with 'go 1.21' #62278
Comments
how did you end up with |
I can't remember exactly, but I think it was rather manual like: |
I am seeing this problem on linux/ppc64le.
|
@matthewhughes-uw, this is as expected: In general if you want to specify a development version in the go 1.21.0 or go 1.21
toolchain go1.21.0 |
@laboger, the problem you are seeing is similar. In particular, if you are working within |
As far as I can tell this is all working as designed. @matthewhughes-uw, are there specific documentation changes that would have helped you solve or avoid this problem? |
👍
I think the main issue was my assumption that, previously I could just specify a language version (per https://go.dev/doc/toolchain#version) i.e.
and within the linked page
so I guess it wasn't clear to me that a "language version" != a "Go release version" (though it was true for every language version before Go 1.21)
🤔 Maybe it's worth documenting something like "If you want to specify a 'language version' in |
S. golang/go#62278 (comment) for details
Set golang version to `v1.21.0`, s. golang/go#62278 (comment)
Set golang version to `v1.21.0`, s. golang/go#62278 (comment)
To add to this: what really happened here that causes a bit of confusion is that the value of Before 1.21 release With 1.21 release you most likely want to put So the way I see it we went from Having now also |
According to [1] as of Go 1.21 we either need to specify the full toolchain version in the `go` directive or add a `toolchain` directive with the concrete toolchain version. Opt for the former and make sure it's kept up to date by renovate bot. [1] golang/go#62278 (comment) Signed-off-by: Tobias Klauser <tobias@cilium.io>
According to [1] as of Go 1.21 we either need to specify the full toolchain version in the `go` directive or add a `toolchain` directive with the concrete toolchain version. Opt for the former and make sure it's kept up to date by renovate bot. [1] golang/go#62278 (comment) Signed-off-by: Tobias Klauser <tobias@cilium.io>
1.23 is not a downloable release. Go mod should list the specific toolchain that can be downloaded as mentioned here: golang/go#62278 (comment) Otherwise opening the project having a different version installed will result in errors, e.g: ``` $ go version go: downloading go1.23 (linux/amd64) go: download go1.23 for linux/amd64: toolchain not available ``` Signed-off-by: Antonio Gutierrez <antonio.gutierrez1@ibm.com>
1.23 is not a downloable release. Go mod should list the specific toolchain that can be downloaded as mentioned here: golang/go#62278 (comment) Otherwise opening the project having a different version installed will result in errors, e.g: ``` $ go version go: downloading go1.23 (linux/amd64) go: download go1.23 for linux/amd64: toolchain not available ``` Signed-off-by: Antonio Gutierrez <antonio.gutierrez1@ibm.com> Co-authored-by: Antonio Gutierrez <antonio.gutierrez1@ibm.com>
Starting with Go version 1.21, the exact minimum Go release version or the toolchain version must be specified in go.mod (see also golang/go#62278 (comment)). So, change the Go version from "1.23" to "1.23.0". Signed-off-by: hwipl <33433250+hwipl@users.noreply.github.com>
Starting with Go version 1.21, the exact minimum Go release version or the toolchain version must be specified in go.mod (see also golang/go#62278 (comment)). So, change the Go version from "1.23" to "1.23.0". Signed-off-by: hwipl <33433250+hwipl@users.noreply.github.com>
Starting with Go version 1.21, the exact minimum Go release version or the toolchain version must be specified in go.mod (see also golang/go#62278 (comment)). So, change the Go version from "1.23" to "1.23.0". Signed-off-by: hwipl <33433250+hwipl@users.noreply.github.com>
Otherwise I'm getting ``` go: download go1.22 for darwin/arm64: toolchain not available ``` on my mac. See golang/go#65568 & golang/go#62278 (comment)
go 1.22 is a development version for which there is no downloadable release, and so 'go' cannot install a proper toolchain for it. See: golang/go#62278 (comment)
Note: I think this is a question of: is "
go 1.21
" a valid go directive? since there was no1.21
release, only1.21.0
, perhaps notWhat version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes, reproduced on Go 1.21.0
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
Given a basic
go.mod
Then run:
What did you expect to see?
go mod tidy
runs successfully. I guess I expect it would pickgo1.21.0
as the toolchain if no toolchain is available as1.21
What did you see instead?
The error output above with a non-zero exit code
More details
The issue was seen when running
dependabot
on a repo with ago 1.21
directive ingo.mod
, theGOTOOLCHAIN
above was taken from their usage https://github.com/dependabot/dependabot-core/blob/08ac25ebd773cede0c00be9a98e5bb03b680870b/go_modules/Dockerfile#L34Running the above command with
GODEBUG=http2debug=1
I see it:go.dev/dl/mod/golang.org/toolchain/@v/v0.0.1-go1.21.linux-amd64.zip
which returnsLocation: https://go.dev/dl/mod/golang.org/toolchain/@v/v0.0.1-go1.21.linux-amd64.zip
location: https://dl.google.com/go/v0.0.1-go1.21.linux-amd64.zip
Updating the directive to:
go 1.21.0
will permit things to run fine.Update: closed per #62278 (comment)
The text was updated successfully, but these errors were encountered: