Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: mod tidy reports toolchain not available with 'go 1.21' #62278

Closed
matthewhughes-uw opened this issue Aug 25, 2023 · 39 comments
Closed

cmd/go: mod tidy reports toolchain not available with 'go 1.21' #62278

matthewhughes-uw opened this issue Aug 25, 2023 · 39 comments
Assignees
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. GoCommand cmd/go
Milestone

Comments

@matthewhughes-uw
Copy link

matthewhughes-uw commented Aug 25, 2023

Note: I think this is a question of: is "go 1.21" a valid go directive? since there was no 1.21 release, only 1.21.0, perhaps not

What version of Go are you using (go version)?

$ go version
go version go1.21.0 linux/amd64

Does this issue reproduce with the latest release?

Yes, reproduced on Go 1.21.0

What operating system and processor architecture are you using (go env)?

go env Output
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/root/.cache/go-build'
GOENV='/root/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21.0'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='0'
GOMOD='/proj/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build435086183=/tmp/go-build -gno-record-gcc-switches'

What did you do?

Given a basic go.mod

$ cat go.mod 
module example.com/foo

go 1.21

Then run:

$ GOTOOLCHAIN="go1.20+auto" go mod tidy
go: downloading go1.21 (linux/amd64)
go: download go1.21 for linux/amd64: toolchain not available

What did you expect to see?

go mod tidy runs successfully. I guess I expect it would pick go1.21.0 as the toolchain if no toolchain is available as 1.21

What did you see instead?

The error output above with a non-zero exit code

More details

The issue was seen when running dependabot on a repo with a go 1.21 directive in go.mod, the GOTOOLCHAIN above was taken from their usage https://github.com/dependabot/dependabot-core/blob/08ac25ebd773cede0c00be9a98e5bb03b680870b/go_modules/Dockerfile#L34

Running the above command with GODEBUG=http2debug=1 I see it:

  • requests go.dev/dl/mod/golang.org/toolchain/@v/v0.0.1-go1.21.linux-amd64.zip which returns Location: https://go.dev/dl/mod/golang.org/toolchain/@v/v0.0.1-go1.21.linux-amd64.zip
  • requesting that URL then returns location: https://dl.google.com/go/v0.0.1-go1.21.linux-amd64.zip
  • requesting that URL gives a 404

Updating the directive to: go 1.21.0 will permit things to run fine.

Update: closed per #62278 (comment)

@matthewhughes-uw matthewhughes-uw changed the title go mod tidy reports toolchain not available with 'go 1.21' go: mod tidy reports toolchain not available with 'go 1.21' Aug 25, 2023
@matthewhughes-uw matthewhughes-uw changed the title go: mod tidy reports toolchain not available with 'go 1.21' cmd/go: mod tidy reports toolchain not available with 'go 1.21' Aug 25, 2023
@seankhliao
Copy link
Member

how did you end up with go 1.21 as a directive?

@matthewhughes-uw
Copy link
Author

matthewhughes-uw commented Aug 25, 2023

how did you end up with go 1.21 as a directive?

I can't remember exactly, but I think it was rather manual like: go1.21.0 mod edit -go=1.21

@laboger
Copy link
Contributor

laboger commented Aug 25, 2023

I am seeing this problem on linux/ppc64le.
I have built a toolchain from the latest go1.21 branch and set up my PATH to use it.
When I cd'ed to cmd/compile/internal/ssa in a toolchain from master that changes the behavior to what is shown above.
I found it when I tried to do 'go generate' but I get the same behavior from just doing 'go version' from within that directory.
If I cd back to another directory then it provides the correct go version.

$ go version
go version go1.21.0 linux/ppc64le
$ cd ~/golang/plain/go/src/cmd/compile/internal/ssa
$ pwd
/home/boger/golang/plain/go/src/cmd/compile/internal/ssa
$ go version
go: downloading go1.22 (linux/ppc64le)
go: download go1.22 for linux/ppc64le: toolchain not available
$ cd ~/gotests
$ go version
go version go1.21.0 linux/ppc64le

@bcmills
Copy link
Contributor

bcmills commented Aug 25, 2023

@matthewhughes-uw, this is as expected: go 1.21 was a development version of the language, for which there is no downloadable release (because it is not a specific version). The release version would be go 1.21.0.

In general if you want to specify a development version in the go line, you must also give a concrete toolchain version. So either of these should work:

go 1.21.0

or

go 1.21
toolchain go1.21.0

@bcmills
Copy link
Contributor

bcmills commented Aug 25, 2023

@laboger, the problem you are seeing is similar. go1.21.0 cannot upgrade automatically to a toolchain that supports go 1.22, because no such toolchain has been released. In order to compile a package in a go 1.22 module, you need to use a development build of the toolchain that supports that language version.

In particular, if you are working within $GOROOT/src you should be using exactly the toolchain built by make.bash within that GOROOT — you may need to re-run make.bash and/or check your $PATH. 😅

@bcmills bcmills added this to the Unplanned milestone Aug 25, 2023
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 25, 2023
@bcmills
Copy link
Contributor

bcmills commented Aug 25, 2023

As far as I can tell this is all working as designed. @matthewhughes-uw, are there specific documentation changes that would have helped you solve or avoid this problem?

@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Aug 25, 2023
@matthewhughes-uw
Copy link
Author

matthewhughes-uw commented Aug 25, 2023

As far as I can tell this is all working as designed

👍

@matthewhughes-uw, are there specific documentation changes that would have helped you solve or avoid this problem?

I think the main issue was my assumption that, previously I could just specify a language version (per https://go.dev/doc/toolchain#version) i.e. go 1.X in my go.mod e.g. go 1.20 but with Go 1.21 I can no longer do this. The docs say:

The version must be a valid Go release version, such as 1.9, 1.14, or 1.21rc1

and within the linked page

The syntax ‘1.N’ is called a “language version”. It denotes the overall family of Go releases implementing that version of the Go language and standard library.

so I guess it wasn't clear to me that a "language version" != a "Go release version" (though it was true for every language version before Go 1.21)

In general if you want to specify a development version in the go line, you must also give a concrete toolchain version. So either of these should work:

🤔 Maybe it's worth documenting something like "If you want to specify a 'language version' in go.mod you should (must? But again, only true for Go 1.21 at the moment) also specify a toolchain version"?

@bcmills bcmills removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Aug 25, 2023
lizthegrey added a commit to lizthegrey/tor-fetcher that referenced this issue Aug 27, 2023
damyan added a commit to ironcore-dev/ipxe that referenced this issue Aug 28, 2023
damyan added a commit to ironcore-dev/inventory that referenced this issue Aug 28, 2023
Set golang version to `v1.21.0`, s. golang/go#62278 (comment)
damyan added a commit to ironcore-dev/FeDHCP that referenced this issue Aug 28, 2023
Set golang version to `v1.21.0`, s. golang/go#62278 (comment)
prymitive added a commit to cloudflare/pint that referenced this issue Aug 29, 2023
@prymitive
Copy link

I think the main issue was my assumption that, previously I could just specify a language version (per https://go.dev/doc/toolchain#version) i.e. go 1.X in my go.mod e.g. go 1.20 but with Go 1.21 I can no longer do this.

To add to this: what really happened here that causes a bit of confusion is that the value of go keyword in go.mod changed it's format.

Before 1.21 release X.Y.Z value (1.20.1) would be invalid so you couldn't put it there.

With 1.21 release you most likely want to put X.Y.Z there since most user would want to put there a real working version, not a dev release.
To add to confusion X.Y value technically works, but it may or may not depending on what was released.

So the way I see it we went from never put .0 to always put .0 (0 being point release number).

Having now also toolchain (which from docs sounds like it's optional) just means that people need to wrap their heads around more complicated set of options to set, as per example from #62278 (comment).

tklauser added a commit to cilium/cilium that referenced this issue Aug 30, 2023
According to [1] as of Go 1.21 we either need to specify the full
toolchain version in the `go` directive or add a `toolchain` directive
with the concrete toolchain version. Opt for the former and make sure
it's kept up to date by renovate bot.

[1] golang/go#62278 (comment)

Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser added a commit to cilium/cilium that referenced this issue Aug 30, 2023
According to [1] as of Go 1.21 we either need to specify the full
toolchain version in the `go` directive or add a `toolchain` directive
with the concrete toolchain version. Opt for the former and make sure
it's kept up to date by renovate bot.

[1] golang/go#62278 (comment)

Signed-off-by: Tobias Klauser <tobias@cilium.io>
itaiad200 added a commit to treeverse/lakeFS that referenced this issue Sep 2, 2024
itaiad200 added a commit to treeverse/lakeFS that referenced this issue Sep 2, 2024
chibby0ne pushed a commit to instana/instana-agent-operator that referenced this issue Sep 9, 2024
1.23 is not a downloable release. Go mod should list the specific
toolchain that can be downloaded as mentioned here:
golang/go#62278 (comment)
Otherwise opening the project having a different version installed will
result in errors, e.g:

```
$ go version
go: downloading go1.23 (linux/amd64)
go: download go1.23 for linux/amd64: toolchain not available
```

Signed-off-by: Antonio Gutierrez <antonio.gutierrez1@ibm.com>
konrad-ohms pushed a commit to instana/instana-agent-operator that referenced this issue Sep 10, 2024
1.23 is not a downloable release. Go mod should list the specific
toolchain that can be downloaded as mentioned here:
golang/go#62278 (comment)
Otherwise opening the project having a different version installed will
result in errors, e.g:

```
$ go version
go: downloading go1.23 (linux/amd64)
go: download go1.23 for linux/amd64: toolchain not available
```

Signed-off-by: Antonio Gutierrez <antonio.gutierrez1@ibm.com>
Co-authored-by: Antonio Gutierrez <antonio.gutierrez1@ibm.com>
hwipl added a commit to telekom-mms/tnd that referenced this issue Sep 12, 2024
Starting with Go version 1.21, the exact minimum Go release version or
the toolchain version must be specified in go.mod (see also
golang/go#62278 (comment)). So,
change the Go version from "1.23" to "1.23.0".

Signed-off-by: hwipl <33433250+hwipl@users.noreply.github.com>
hwipl added a commit to telekom-mms/fw-id-agent that referenced this issue Sep 12, 2024
Starting with Go version 1.21, the exact minimum Go release version or
the toolchain version must be specified in go.mod (see also
golang/go#62278 (comment)). So,
change the Go version from "1.23" to "1.23.0".

Signed-off-by: hwipl <33433250+hwipl@users.noreply.github.com>
hwipl added a commit to telekom-mms/oc-daemon that referenced this issue Sep 12, 2024
Starting with Go version 1.21, the exact minimum Go release version or
the toolchain version must be specified in go.mod (see also
golang/go#62278 (comment)). So,
change the Go version from "1.23" to "1.23.0".

Signed-off-by: hwipl <33433250+hwipl@users.noreply.github.com>
yperbasis added a commit to erigontech/erigon that referenced this issue Sep 12, 2024
Otherwise I'm getting
```
go: download go1.22 for darwin/arm64: toolchain not available
```
on my mac.

See golang/go#65568 &
golang/go#62278 (comment)
marshall007 added a commit to defenseunicorns/uds-security-hub that referenced this issue Sep 17, 2024
marshall007 added a commit to defenseunicorns/uds-security-hub that referenced this issue Sep 17, 2024
bevzzz added a commit to bevzzz/weaviate that referenced this issue Oct 7, 2024
go 1.22 is a development version for which there is no downloadable release,
and so 'go' cannot install a proper toolchain for it.

See: golang/go#62278 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. GoCommand cmd/go
Projects
None yet
Development

No branches or pull requests