chore: Fix race conditions around stager, enable detector #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the race conditions from setting stage.Current from multiple go routines by upgrading to a newer version of go-progress that includes an atomic version of stager and using that. Enable race detection on unit tests, and on a single invocation of the main command under the integration target. Signed-off-by: Will Murphy <will.murphy@anchore.com>
spiffcs
approved these changes
Sep 12, 2023
This was referenced Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the race conditions from setting stage.Current from multiple go routines by upgrading to a newer version of go-progress that includes an atomic version of stager and using that. Enable race detection on unit tests, and on a single invocation of the main command under the integration target.