Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure failing fast on Enterprise image add failures #117

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

bradleyjones
Copy link
Member

  • fix: ensure fail fast if image cannot be uploaded to Enterprise
  • fix: raise the entire error in harbor response on image add failure

This will help to speed up debugging the route cause of image add
failures as the error will bubble up to the log visible inside of the
Harbor UI. In particular this will help in the case where images cannot
be pulled due to vulnerabilities being present in the image as a result
of Harbor configuration.

Signed-off-by: Bradley Jones <bradley.jones@anchore.com>
This will help to speed up debugging the route cause of image add
failures as the error will bubble up to the log visible inside of the
Harbor UI. In particular this will help in the case where images cannot
be pulled due to vulnerabilities being present in the image as a result
of Harbor configuration.

Signed-off-by: Bradley Jones <bradley.jones@anchore.com>
@bradleyjones bradleyjones requested a review from a team as a code owner January 8, 2024 23:04
Copy link

@svietry svietry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bradleyjones bradleyjones merged commit cd6832a into main Jan 9, 2024
4 checks passed
@bradleyjones bradleyjones deleted the error-on-image-add branch January 9, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants