Skip to content

Commit

Permalink
need capitalized http methods (#119)
Browse files Browse the repository at this point in the history
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
  • Loading branch information
wagoodman committed Aug 25, 2023
1 parent 4a41bd8 commit 8129c58
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions quill/notary/http_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ func newHTTPClient(token string, httpTimeout time.Duration) *httpClient {
}

func (s httpClient) get(ctx context.Context, endpoint string, body io.Reader) (*http.Response, error) {
request, err := http.NewRequest("get", endpoint, body)
request, err := http.NewRequest(http.MethodGet, endpoint, body)
if err != nil {
return nil, err
}
Expand All @@ -38,7 +38,7 @@ func (s httpClient) get(ctx context.Context, endpoint string, body io.Reader) (*
}

func (s httpClient) post(ctx context.Context, endpoint string, body io.Reader) (*http.Response, error) {
request, err := http.NewRequest("post", endpoint, body)
request, err := http.NewRequest(http.MethodPost, endpoint, body)
if err != nil {
return nil, err
}
Expand Down
4 changes: 2 additions & 2 deletions quill/notary/http_client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (

func Test_httpClient_get(t *testing.T) {
s := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, "get", r.Method)
assert.Equal(t, "GET", r.Method)
return
}))
defer s.Close()
Expand All @@ -27,7 +27,7 @@ func Test_httpClient_get(t *testing.T) {

func Test_httpClient_post(t *testing.T) {
s := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, "post", r.Method)
assert.Equal(t, "POST", r.Method)
return
}))
defer s.Close()
Expand Down

0 comments on commit 8129c58

Please sign in to comment.