Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change draft to false for release process #1016

Merged
merged 1 commit into from
Jun 1, 2022
Merged

change draft to false for release process #1016

merged 1 commit into from
Jun 1, 2022

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented May 26, 2022

In cases where a draft is released and not published, users will encounter brew install issues along with other friction regarding the new release.

Bumping this to just cut a release with note/artifact edits being done after the fact will reduce this friction.

Signed-off-by: Christopher Phillips christopher.phillips@anchore.com

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.46ms ± 5%    1.50ms ± 2%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            3.47ms ± 3%    3.81ms ± 2%   +9.79%  (p=0.016 n=5+4)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.14ms ± 3%    1.23ms ± 3%   +8.05%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         790µs ± 4%     822µs ± 3%   +4.06%  (p=0.032 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     929µs ± 1%     973µs ± 1%   +4.65%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      847µs ± 4%     871µs ± 1%   +2.90%  (p=0.032 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      15.3ms ± 2%    17.4ms ± 1%  +13.55%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.31ms ± 4%    1.44ms ± 3%  +10.20%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.55µs ± 6%    2.67µs ± 2%     ~     (p=0.095 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.57ms ± 6%    1.60ms ± 2%     ~     (p=0.548 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               184kB ± 0%     184kB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             891kB ± 0%     892kB ± 0%     ~     (p=0.056 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     196kB ± 0%     196kB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         140kB ± 0%     140kB ± 0%     ~     (p=0.889 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     175kB ± 0%     175kB ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      164kB ± 0%     164kB ± 0%     ~     (p=0.222 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.28MB ± 0%    3.28MB ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.23MB ± 0%    1.23MB ± 0%     ~     (p=0.095 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            672B ± 0%      672B ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                351kB ± 0%     351kB ± 0%     ~     (p=0.222 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               3.71k ± 0%     3.71k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             14.9k ± 0%     14.9k ± 0%     ~     (p=0.667 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     4.98k ± 0%     4.98k ± 0%     ~     (p=0.238 n=4+5)
ImagePackageCatalogers/javascript-package-cataloger-2         2.76k ± 0%     2.76k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.00k ± 0%     4.00k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      4.06k ± 0%     4.06k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       52.6k ± 0%     52.6k ± 0%     ~     (p=0.333 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      4.87k ± 0%     4.87k ± 0%   +0.02%  (p=0.048 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            15.0 ± 0%      15.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                6.72k ± 0%     6.72k ± 0%     ~     (all equal)

@spiffcs spiffcs merged commit 82de24c into main Jun 1, 2022
@spiffcs spiffcs deleted the no-draft branch June 1, 2022 15:55
@spiffcs spiffcs added the changelog-ignore Don't include this issue in the release changelog label Jun 1, 2022
spiffcs added a commit to jonasagx/syft that referenced this pull request Jun 27, 2022
* main: (70 commits)
  fix: add php catalogers to all catalogers (anchore#1065)
  feat: add use-all-catalogers flag (anchore#1050)
  Updates parsing of `yarn.lock` to use `resolved` URLs that are pulled from yarn and npm registries (anchore#926)
  remove OSS Meetup message (anchore#1057)
  add pom.xml cataloger (anchore#1055)
  Add support for CBL-Mariner distroless images (anchore#1045)
  Add catalogers configuration (anchore#1038)
  add template output (anchore#1051)
  update stereoscope to latest version (anchore#1052)
  update zip_read_closer to incorporate zip64 support (anchore#1041)
  Add pacman (alpm) parser support (anchore#943)
  Update of README.md (anchore#1027)
  bump cosign to v1.9.0 to resolve reporting of GHSA-66x3-6cw3-v5gj (anchore#1025)
  add workflows to test new project automation (anchore#1023)
  improve LanguageByName and add unit tests (anchore#1034)
  Read Description from dpkg status files (anchore#996)
  Add announcement for Anchore OSS Virtual Meetup (anchore#1033)
  add main module field to go bin metadata (anchore#1026)
  Add filters to package cataloger (anchore#1021)
  change draft to false for release process (anchore#1016)
  ...

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
aiwantaozi pushed a commit to aiwantaozi/syft that referenced this pull request Oct 20, 2022
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-ignore Don't include this issue in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants