Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump cosign to v1.9.0 to resolve reporting of GHSA-66x3-6cw3-v5gj #1025

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

westonsteimel
Copy link
Contributor

Signed-off-by: Weston Steimel weston.steimel@anchore.com

Signed-off-by: Weston Steimel <weston.steimel@anchore.com>
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.21ms ± 1%    1.20ms ± 1%    ~     (p=0.310 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            3.09ms ± 1%    2.97ms ± 0%  -3.91%  (p=0.029 n=4+4)
ImagePackageCatalogers/php-composer-installed-cataloger-2     981µs ± 0%     975µs ± 2%    ~     (p=0.548 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         656µs ± 0%     643µs ± 1%  -2.06%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     785µs ± 0%     773µs ± 1%  -1.55%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      760µs ± 0%     748µs ± 1%  -1.57%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      14.3ms ± 1%    14.1ms ± 1%  -1.07%  (p=0.032 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.20ms ± 1%    1.13ms ± 0%  -6.56%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.25µs ± 2%    2.12µs ± 1%  -5.51%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.33ms ± 1%    1.26ms ± 0%  -5.51%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               184kB ± 0%     184kB ± 0%    ~     (p=0.897 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             890kB ± 0%     889kB ± 0%    ~     (p=0.548 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     196kB ± 0%     196kB ± 0%    ~     (p=0.841 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         140kB ± 0%     140kB ± 0%    ~     (p=0.794 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     175kB ± 0%     184kB ± 0%  +5.25%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      212kB ± 0%     215kB ± 0%  +1.63%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.28MB ± 0%    3.27MB ± 0%    ~     (p=0.548 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.23MB ± 0%    1.23MB ± 0%    ~     (p=0.222 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            672B ± 0%      672B ± 0%    ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                351kB ± 0%     351kB ± 0%  +0.04%  (p=0.016 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               3.70k ± 0%     3.71k ± 0%    ~     (p=0.444 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             14.9k ± 0%     14.9k ± 0%    ~     (p=0.452 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     4.98k ± 0%     4.99k ± 0%    ~     (p=0.238 n=5+4)
ImagePackageCatalogers/javascript-package-cataloger-2         2.76k ± 0%     2.76k ± 0%    ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.00k ± 0%     4.04k ± 0%  +0.80%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      5.03k ± 0%     5.26k ± 0%  +4.61%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                       52.6k ± 0%     52.6k ± 0%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      4.87k ± 0%     4.87k ± 0%    ~     (p=0.079 n=4+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            15.0 ± 0%      15.0 ± 0%    ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                6.72k ± 0%     6.72k ± 0%    ~     (all equal)

@spiffcs
Copy link
Contributor

spiffcs commented Jun 3, 2022

Looks like this is a large change to their library code! I'll take a look here as soon as I have time to see what we can refactor so we can stay in sync.

Thanks for the nudge that this should be updated

@spiffcs spiffcs self-assigned this Jun 8, 2022
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@spiffcs spiffcs marked this pull request as ready for review June 8, 2022 15:31
@spiffcs spiffcs merged commit b8d1a46 into main Jun 8, 2022
@spiffcs spiffcs deleted the bump-cosign-v1.9.0 branch June 8, 2022 15:51
spiffcs added a commit to jonasagx/syft that referenced this pull request Jun 27, 2022
* main: (70 commits)
  fix: add php catalogers to all catalogers (anchore#1065)
  feat: add use-all-catalogers flag (anchore#1050)
  Updates parsing of `yarn.lock` to use `resolved` URLs that are pulled from yarn and npm registries (anchore#926)
  remove OSS Meetup message (anchore#1057)
  add pom.xml cataloger (anchore#1055)
  Add support for CBL-Mariner distroless images (anchore#1045)
  Add catalogers configuration (anchore#1038)
  add template output (anchore#1051)
  update stereoscope to latest version (anchore#1052)
  update zip_read_closer to incorporate zip64 support (anchore#1041)
  Add pacman (alpm) parser support (anchore#943)
  Update of README.md (anchore#1027)
  bump cosign to v1.9.0 to resolve reporting of GHSA-66x3-6cw3-v5gj (anchore#1025)
  add workflows to test new project automation (anchore#1023)
  improve LanguageByName and add unit tests (anchore#1034)
  Read Description from dpkg status files (anchore#996)
  Add announcement for Anchore OSS Virtual Meetup (anchore#1033)
  add main module field to go bin metadata (anchore#1026)
  Add filters to package cataloger (anchore#1021)
  change draft to false for release process (anchore#1016)
  ...

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
aiwantaozi pushed a commit to aiwantaozi/syft that referenced this pull request Oct 20, 2022
…chore#1025)

Co-authored-by: Christopher Phillips <christopher.phillips@anchore.com>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
…chore#1025)

Co-authored-by: Christopher Phillips <christopher.phillips@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants