-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not leak attestation password or key path to console or SBOM contents #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch
|
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
wagoodman
reviewed
Feb 3, 2023
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
wagoodman
approved these changes
Feb 3, 2023
This was referenced Feb 6, 2023
This was referenced Feb 13, 2023
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
* fix: update config struct to not decode password/key * test: update tests to confirm no secrets in output Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com> --------- Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
key
andpassword
config fields when runningsyft attest
to not be displayed in the console or encoded into SBOMs.In the previous state plain text of the fields would be output during a syft run where the
config
is printed to the console. This is NOT the desired behavior. Instead, this change updates the tag values so that the fields are ignored and not decoded onto theyaml
orjson
outputs displayed by syft.Note - the code can still use these values, but they are no longer exposed as a part of any logging or encoded into SBOMs.
Affects syft versions >= v0.69.0 && <0.70.0
Related Links:
Signed-off-by: Christopher Phillips christopher.phillips@anchore.com