Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for macos github actions cache issue #1584

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

wagoodman
Copy link
Contributor

A temporary workaround to account for failing acceptance tests due to a false cache miss on mac runners in CI. See actions/cache#1110 for more details.

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch
goos: linux
goarch: amd64
pkg: github.com/anchore/syft/test/integration
cpu: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
                                                          │ ./.tmp/benchmark-e7f5316.txt │
                                                          │            sec/op            │
ImagePackageCatalogers/alpmdb-cataloger-2                                    13.02m ± 1%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                              922.3µ ± 7%
ImagePackageCatalogers/python-package-cataloger-2                            3.424m ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2                    718.9µ ± 1%
ImagePackageCatalogers/javascript-package-cataloger-2                        419.1µ ± 1%
ImagePackageCatalogers/dpkgdb-cataloger-2                                    536.8µ ± 2%
ImagePackageCatalogers/rpm-db-cataloger-2                                    549.0µ ± 3%
ImagePackageCatalogers/java-cataloger-2                                      11.95m ± 2%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                      8.805µ ± 2%
ImagePackageCatalogers/apkdb-cataloger-2                                     513.3µ ± 1%
ImagePackageCatalogers/go-module-binary-cataloger-2                          19.02µ ± 1%
ImagePackageCatalogers/dotnet-deps-cataloger-2                               1.081m ± 2%
ImagePackageCatalogers/portage-cataloger-2                                   337.8µ ± 3%
ImagePackageCatalogers/sbom-cataloger-2                                      109.6µ ± 1%
ImagePackageCatalogers/binary-cataloger-2                                    146.9µ ± 1%
geomean                                                                      489.3µ

                                                          │ ./.tmp/benchmark-e7f5316.txt │
                                                          │             B/op             │
ImagePackageCatalogers/alpmdb-cataloger-2                                   5.060Mi ± 0%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                             141.7Ki ± 0%
ImagePackageCatalogers/python-package-cataloger-2                           946.7Ki ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2                   155.9Ki ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2                       95.64Ki ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                                   144.6Ki ± 0%
ImagePackageCatalogers/rpm-db-cataloger-2                                   170.4Ki ± 0%
ImagePackageCatalogers/java-cataloger-2                                     2.721Mi ± 0%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                     1.523Ki ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                                    123.0Ki ± 0%
ImagePackageCatalogers/go-module-binary-cataloger-2                         3.102Ki ± 0%
ImagePackageCatalogers/dotnet-deps-cataloger-2                              314.2Ki ± 0%
ImagePackageCatalogers/portage-cataloger-2                                  75.44Ki ± 0%
ImagePackageCatalogers/sbom-cataloger-2                                     13.05Ki ± 0%
ImagePackageCatalogers/binary-cataloger-2                                   20.56Ki ± 0%
geomean                                                                     106.7Ki

                                                          │ ./.tmp/benchmark-e7f5316.txt │
                                                          │          allocs/op           │
ImagePackageCatalogers/alpmdb-cataloger-2                                    86.71k ± 0%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                              2.159k ± 0%
ImagePackageCatalogers/python-package-cataloger-2                            15.48k ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2                    3.457k ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2                        1.253k ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                                    2.646k ± 0%
ImagePackageCatalogers/rpm-db-cataloger-2                                    3.759k ± 0%
ImagePackageCatalogers/java-cataloger-2                                      38.26k ± 0%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                       40.00 ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                                     3.251k ± 0%
ImagePackageCatalogers/go-module-binary-cataloger-2                           101.0 ± 0%
ImagePackageCatalogers/dotnet-deps-cataloger-2                               5.011k ± 0%
ImagePackageCatalogers/portage-cataloger-2                                   1.487k ± 0%
ImagePackageCatalogers/sbom-cataloger-2                                       392.0 ± 0%
ImagePackageCatalogers/binary-cataloger-2                                     609.0 ± 0%
geomean                                                                      2.170k

@wagoodman wagoodman merged commit 0076b19 into main Feb 17, 2023
@wagoodman wagoodman deleted the mac-cache-workaround branch February 17, 2023 15:29
wagoodman added a commit that referenced this pull request Feb 22, 2023
wagoodman added a commit that referenced this pull request Feb 22, 2023
This reverts commit 0076b19.

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
wagoodman added a commit that referenced this pull request Feb 22, 2023
…1605)

This reverts commit 0076b19.

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
noqcks pushed a commit to noqcks/syft that referenced this pull request Feb 23, 2023
…1584)" (anchore#1605)

This reverts commit 0076b19.

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
noqcks added a commit to noqcks/syft that referenced this pull request Feb 23, 2023
Signed-off-by: Benji Visser <benji@093b.org>

chore: update SPDX license list (anchore#1599)

Update SPDX license list to 3.20 (anchore#1600)

Signed-off-by: Marc-Etienne Vargenau <marc-etienne.vargenau@nokia.com>

Update Stereoscope to 529924d6d5aa6c708cceffc651883b6e1e27f5df (anchore#1602)

Signed-off-by: GitHub <noreply@github.com>

feat: add perl binary classifier (anchore#1592)

Signed-off-by: Benji Visser <benji@093b.org>

chore: update syft bootstrap tools to latest versions. (anchore#1593)

fix: issue when matching format versions (anchore#1585)

Signed-off-by: Keith Zantow <kzantow@gmail.com>

fix: merging of binary packages (anchore#1583)

chore: fix cataloger_test (anchore#1603)

Signed-off-by: Keith Zantow <kzantow@gmail.com>

Update Stereoscope to fab1c9638abc2c21cd53dca1f205f37d71148ee0 (anchore#1604)

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: wagoodman <wagoodman@users.noreply.github.com>

Revert "add workaround for macos github actions cache issue (anchore#1584)" (anchore#1605)

This reverts commit 0076b19.

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

remove schema 6.2.1

Signed-off-by: Benji Visser <benji@093b.org>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
…1584)" (anchore#1605)

This reverts commit da0c8ed.

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants