1948-filter-pkg-by-type

[spiffcs]

Summary

After #1948 was merged a few more comments were made regarding certain aspects of the PR.

This addition addresses those comments by updating the exclusion approach. We no longer filter based on the cataloger that found the pkg, but the pkg type in relation to the synthetic binary pkg type

[github-actions]

Benchmark Test Results

Benchmark results from the latest changes vs base branch

goos: linux%0Agoarch: amd64%0Apkg: github.com/anchore/syft/test/integration%0Acpu: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz%0A                                                              │ ./.tmp/benchmark-3c64e8a.txt │%0A                                                              │            sec/op            │%0AImagePackageCatalogers/alpmdb-cataloger-2                                       15.95m ±  3%25%0AImagePackageCatalogers/apkdb-cataloger-2                                        1.000m ±  6%25%0AImagePackageCatalogers/binary-cataloger-2                                       284.9µ ±  5%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                       884.9µ ±  7%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                   31.21µ ±  3%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                             137.0µ ±  3%25%0AImagePackageCatalogers/java-cataloger-2                                         17.54m ±  8%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                         140.4µ ±  3%25%0AImagePackageCatalogers/javascript-package-cataloger-2                           540.8µ ± 25%25%0AImagePackageCatalogers/nix-store-cataloger-2                                    394.3µ ±  3%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                       1.057m ±  8%25%0AImagePackageCatalogers/portage-cataloger-2                                      652.2µ ±  3%25%0AImagePackageCatalogers/python-package-cataloger-2                               4.269m ±  5%25%0AImagePackageCatalogers/r-package-cataloger-2                                    310.5µ ±  6%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                       769.9µ ±  5%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                 1.291m ±  4%25%0AImagePackageCatalogers/sbom-cataloger-2                                         160.8µ ±  4%25%0Ageomean                                                                         677.0µ%0A%0A                                                              │ ./.tmp/benchmark-3c64e8a.txt │%0A                                                              │             B/op             │%0AImagePackageCatalogers/alpmdb-cataloger-2                                       5.142Mi ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                        205.6Ki ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                       30.46Ki ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                       172.5Ki ± 0%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                   3.695Ki ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                             9.906Ki ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                         2.843Mi ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                         8.595Ki ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                           94.21Ki ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                    49.32Ki ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                       186.5Ki ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                      120.2Ki ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                               1.003Mi ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                    53.29Ki ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                       181.4Ki ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                 144.0Ki ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                         14.20Ki ± 0%25%0Ageomean                                                                         100.6Ki%0A%0A                                                              │ ./.tmp/benchmark-3c64e8a.txt │%0A                                                              │          allocs/op           │%0AImagePackageCatalogers/alpmdb-cataloger-2                                        88.14k ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                         4.190k ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                         848.0 ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                        3.145k ± 0%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                     132.0 ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                               281.0 ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                          40.19k ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                           228.0 ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                            1.342k ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                      898.0 ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                        4.079k ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                       2.272k ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                                16.44k ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                      929.0 ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                        3.992k ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                  2.447k ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                           394.0 ± 0%25%0Ageomean                                                                          2.062k

[wagoodman]

thanks for the adjustments 🙏 probably should also use the changelog-ignore label on this PR