Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdx): validate external refs before encoding #2091

Merged

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Sep 4, 2023

Fixes #2079

PR description

Validate extracted metadata before encoding into output file as external_references.

Notes

  • Test added

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber hainenber force-pushed the only-encode-valid-url-as-external-ref branch from c7d7558 to f36ee46 Compare September 4, 2023 09:56
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @hainenber 👍

@kzantow kzantow enabled auto-merge (squash) September 5, 2023 14:29
@kzantow kzantow merged commit 305ee87 into anchore:main Sep 5, 2023
9 checks passed
@hainenber hainenber deleted the only-encode-valid-url-as-external-ref branch September 5, 2023 14:42
spiffcs added a commit to dlorenc/syft that referenced this pull request Sep 7, 2023
* main:
  chore(deps): update bootstrap tools to latest versions (anchore#2086)
  chore(deps): update CPE dictionary index (anchore#2089)
  chore(deps): bump github.com/saferwall/pe from 1.4.4 to 1.4.5 (anchore#2096)
  chore(deps): bump github.com/docker/docker (anchore#2098)
  chore(deps): bump golang.org/x/net from 0.14.0 to 0.15.0 (anchore#2099)
  feat(cmd/update): add UA header with current ver when check for update (anchore#2100)
  fix(cdx): validate external refs before encoding (anchore#2091)
  expose cobra command in cli package (anchore#2097)

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: hainenber <dotronghai96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cyclonedx external reference URLs are not validated when encoding
2 participants