Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose cobra command in cli package #2097

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Expose cobra command in cli package #2097

merged 1 commit into from
Sep 5, 2023

Conversation

wagoodman
Copy link
Contributor

This allows for consuming applications to use the cobra command directly, which allows for embedding the syft cli into another cli easily. We might do this in the future up in clio but decided to hold off on that for now (related PR anchore/clio#26 ).

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wagoodman wagoodman enabled auto-merge (squash) September 5, 2023 14:27
@wagoodman wagoodman added the enhancement New feature or request label Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Benchmark Test Results

Benchmark results from the latest changes vs base branch
goos: linux%0Agoarch: amd64%0Apkg: github.com/anchore/syft/test/integration%0Acpu: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz%0A                                                              │ ./.tmp/benchmark-43e8801.txt │%0A                                                              │            sec/op            │%0AImagePackageCatalogers/alpmdb-cataloger-2                                       15.31m ±  3%25%0AImagePackageCatalogers/apkdb-cataloger-2                                        877.9µ ±  2%25%0AImagePackageCatalogers/binary-cataloger-2                                       255.3µ ±  2%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                       733.4µ ±  3%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                   27.09µ ±  1%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                             113.6µ ±  1%25%0AImagePackageCatalogers/java-cataloger-2                                         25.90m ±  1%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                         110.3µ ± 20%25%0AImagePackageCatalogers/javascript-package-cataloger-2                           463.5µ ±  1%25%0AImagePackageCatalogers/nix-store-cataloger-2                                    339.5µ ±  3%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                       972.4µ ±  3%25%0AImagePackageCatalogers/portage-cataloger-2                                      608.7µ ±  7%25%0AImagePackageCatalogers/python-package-cataloger-2                               4.142m ±  2%25%0AImagePackageCatalogers/r-package-cataloger-2                                    245.5µ ±  2%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                       664.1µ ±  1%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                 1.128m ±  2%25%0AImagePackageCatalogers/sbom-cataloger-2                                         145.5µ ±  1%25%0Ageomean                                                                         610.7µ%0A%0A                                                              │ ./.tmp/benchmark-43e8801.txt │%0A                                                              │             B/op             │%0AImagePackageCatalogers/alpmdb-cataloger-2                                       5.134Mi ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                        184.6Ki ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                       30.77Ki ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                       141.3Ki ± 0%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                   3.696Ki ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                             9.891Ki ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                         3.387Mi ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                         8.594Ki ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                           83.82Ki ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                    38.93Ki ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                       155.4Ki ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                      109.8Ki ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                               986.2Ki ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                    42.90Ki ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                       170.9Ki ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                 123.2Ki ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                         14.20Ki ± 0%25%0Ageomean                                                                         93.58Ki%0A%0A                                                              │ ./.tmp/benchmark-43e8801.txt │%0A                                                              │          allocs/op           │%0AImagePackageCatalogers/alpmdb-cataloger-2                                        88.06k ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                         4.034k ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                         866.0 ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                        2.911k ± 0%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                     132.0 ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                               280.0 ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                          44.28k ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                           228.0 ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                            1.264k ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                      820.0 ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                        3.845k ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                       2.194k ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                                16.13k ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                      851.0 ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                        3.914k ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                  2.291k ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                           394.0 ± 0%25%0Ageomean                                                                          2.009k

@wagoodman wagoodman merged commit 49e7f39 into main Sep 5, 2023
9 checks passed
@wagoodman wagoodman deleted the expose-cobra-command branch September 5, 2023 14:33
spiffcs added a commit to dlorenc/syft that referenced this pull request Sep 7, 2023
* main:
  chore(deps): update bootstrap tools to latest versions (anchore#2086)
  chore(deps): update CPE dictionary index (anchore#2089)
  chore(deps): bump github.com/saferwall/pe from 1.4.4 to 1.4.5 (anchore#2096)
  chore(deps): bump github.com/docker/docker (anchore#2098)
  chore(deps): bump golang.org/x/net from 0.14.0 to 0.15.0 (anchore#2099)
  feat(cmd/update): add UA header with current ver when check for update (anchore#2100)
  fix(cdx): validate external refs before encoding (anchore#2091)
  expose cobra command in cli package (anchore#2097)

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants