Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary classifier for the ERLang interpreter #2417

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

LaurentGoderre
Copy link
Contributor

No description provided.

@spiffcs
Copy link
Contributor

spiffcs commented Dec 13, 2023

👋 Thanks for the pull request @LaurentGoderre!

I saw this comment added with respect to nginx

// [NUL]nginx version: nginx/1.25.1 - fetches '1.25.1'
// <artificial>[NUL]/usr/local/src/otp-25.3.2.7/erts/

I'm a little confused to how the above relates to the string we're trying to match on to identify the erlang interpreter. Can you explain how the two are linked?

Also cc @anchore/tools - I know we've been discussing a bit offline about not having binary or other artifacts contributed into the syft test directories. Is this a good candidate to lift these tests into the top level test/ directory where we can fetch the artifacts we want to classify rather than have them commited?

Signed-off-by: Laurent Goderre <laurent.goderre@docker.com>
@LaurentGoderre
Copy link
Contributor Author

LaurentGoderre commented Dec 13, 2023

@spiffcs it isn't forgot to remove the line from the copy-paste. Fixed!

@spiffcs spiffcs merged commit a635d66 into anchore:main Dec 18, 2023
10 checks passed
spiffcs added a commit to LaurentGoderre/syft that referenced this pull request Dec 18, 2023
* main: (30 commits)
  Add binary classifier for the ERLang interpretter (anchore#2417)
  Add binary classifier for Julia lang (anchore#2427)
  Add binary detection for PHP composer (anchore#2432)
  chore(deps): bump actions/upload-artifact from 3.1.3 to 4.0.0 (anchore#2433)
  chore(deps): update CPE dictionary index (anchore#2442)
  chore(deps): update stereoscope to 4b999b76ca8901d15bb97aef445dc94c38d11d5c (anchore#2440)
  fix syft-json test to use pretty json for snapshot testing (anchore#2441)
  refactor pkg.Collection (anchore#2439)
  refactor javascript cataloger to use configuration options when creating packages (anchore#2438)
  use single source of truth for archive options (anchore#2437)
  fix file digest cataloger when passed coordinates (anchore#2436)
  chore(deps): bump github.com/CycloneDX/cyclonedx-go from 0.7.2 to 0.8.0 (anchore#2413)
  Look for a maven version in a pom from a parent dependency management section (anchore#2423)
  Parse Python licenses from LicenseExpression entry in the Wheel Metadata (anchore#2431)
  chore(deps): bump github/codeql-action from 2.22.10 to 3.22.11 (anchore#2430)
  chore(deps): bump modernc.org/sqlite from 1.27.0 to 1.28.0 (anchore#2429)
  chore(deps): update tools to latest versions (anchore#2428)
  Parse Python licenses from LicenseFile entry in the Wheel Metadata (anchore#2331)
  fix: use filepath instead of path for file source exclusions (anchore#2411)
  chore(deps): bump github.com/charmbracelet/bubbletea (anchore#2424)
  ...
@LaurentGoderre LaurentGoderre deleted the erlang branch December 18, 2023 20:24
@willmurphyscode willmurphyscode added the enhancement New feature or request label Dec 21, 2023
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Laurent Goderre <laurent.goderre@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants