Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Python licenses from LicenseFile entry in the Wheel Metadata #2331

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

coheigea
Copy link
Contributor

Syft only finds Python licenses if the Wheel metadata contains a "License" entry. This PR adds support to also parse the License-File entry. With this PR, Syft finds licenses for these packages:

/PyGithub:1.58.2,LGPL-3.0-only
/django-watson:1.6.3,BSD-3-Clause
/setuptools:65.5.1,MIT

Further PRs will follow with enhanced support.

Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org>
@coheigea
Copy link
Contributor Author

bump for a review @wagoodman

@coheigea
Copy link
Contributor Author

coheigea commented Dec 7, 2023

Reminder on this one please @spiffcs @wagoodman

@spiffcs spiffcs merged commit d39ef44 into anchore:main Dec 13, 2023
10 checks passed
@coheigea coheigea deleted the coheigea/python-LicenseFile branch December 14, 2023 07:08
spiffcs added a commit to LaurentGoderre/syft that referenced this pull request Dec 18, 2023
* main: (30 commits)
  Add binary classifier for the ERLang interpretter (anchore#2417)
  Add binary classifier for Julia lang (anchore#2427)
  Add binary detection for PHP composer (anchore#2432)
  chore(deps): bump actions/upload-artifact from 3.1.3 to 4.0.0 (anchore#2433)
  chore(deps): update CPE dictionary index (anchore#2442)
  chore(deps): update stereoscope to 4b999b76ca8901d15bb97aef445dc94c38d11d5c (anchore#2440)
  fix syft-json test to use pretty json for snapshot testing (anchore#2441)
  refactor pkg.Collection (anchore#2439)
  refactor javascript cataloger to use configuration options when creating packages (anchore#2438)
  use single source of truth for archive options (anchore#2437)
  fix file digest cataloger when passed coordinates (anchore#2436)
  chore(deps): bump github.com/CycloneDX/cyclonedx-go from 0.7.2 to 0.8.0 (anchore#2413)
  Look for a maven version in a pom from a parent dependency management section (anchore#2423)
  Parse Python licenses from LicenseExpression entry in the Wheel Metadata (anchore#2431)
  chore(deps): bump github/codeql-action from 2.22.10 to 3.22.11 (anchore#2430)
  chore(deps): bump modernc.org/sqlite from 1.27.0 to 1.28.0 (anchore#2429)
  chore(deps): update tools to latest versions (anchore#2428)
  Parse Python licenses from LicenseFile entry in the Wheel Metadata (anchore#2331)
  fix: use filepath instead of path for file source exclusions (anchore#2411)
  chore(deps): bump github.com/charmbracelet/bubbletea (anchore#2424)
  ...
@willmurphyscode willmurphyscode added the enhancement New feature or request label Dec 21, 2023
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
…nchore#2331)

Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants