Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lower log file permissions to 0644 #511

Merged
merged 1 commit into from Sep 21, 2021
Merged

lower log file permissions to 0644 #511

merged 1 commit into from Sep 21, 2021

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Sep 21, 2021

Removes permissive file creation and sets default to 0644

Signed-off-by: Christopher Angelo Phillips christopher.phillips@anchore.com

@spiffcs spiffcs requested a review from a team September 21, 2021 13:55
kzantow
kzantow approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good change :)

luhring
luhring approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@luhring luhring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link

github-actions bot commented Sep 21, 2021 •
edited

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                   old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2          1.06ms ± 3%    0.79ms ± 3%  -25.65%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2        1.52ms ± 6%    1.11ms ± 2%  -27.05%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     547µs ± 4%     394µs ± 3%  -28.04%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 537µs ± 4%     380µs ± 3%  -29.28%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  551µs ± 2%     403µs ± 1%  -26.86%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  11.4ms ± 4%     8.3ms ± 4%  -27.61%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  739µs ± 3%     546µs ± 4%  -26.20%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-cataloger-2                     281µs ± 1%     208µs ± 1%  -25.91%  (p=0.008 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                   475µs ± 5%     349µs ± 7%  -26.49%  (p=0.008 n=5+5)

name                                                   old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           133kB ± 0%     133kB ± 0%     ~     (p=0.952 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2         643kB ± 0%     643kB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     116kB ± 0%     116kB ± 0%     ~     (p=0.135 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 127kB ± 0%     127kB ± 0%   -0.15%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  138kB ± 0%     138kB ± 0%     ~     (p=0.159 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  2.64MB ± 0%    2.64MB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                 1.16MB ± 0%    1.16MB ± 0%   -0.00%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-cataloger-2                    52.8kB ± 0%    52.9kB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                   110kB ± 0%     110kB ± 0%     ~     (p=0.183 n=5+5)

name                                                   old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           2.04k ± 0%     2.04k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2         6.14k ± 0%     6.14k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     1.93k ± 0%     1.93k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                 2.41k ± 0%     2.41k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                  3.20k ± 0%     3.20k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                   34.8k ± 0%     34.8k ± 0%     ~     (p=0.921 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  1.92k ± 0%     1.92k ± 0%     ~     (all equal)
ImagePackageCatalogers/go-cataloger-2                     1.42k ± 0%     1.42k ± 0%     ~     (all equal)
ImagePackageCatalogers/rust-cataloger-2                   2.83k ± 0%     2.83k ± 0%     ~     (all equal)

@spiffcs
update file permissions to 0644
ca00826 
Signed-off-by: Christopher Angelo Phillips <christopher.phillips@anchore.com>
@spiffcs spiffcs merged commit 3e8afc5 into main Sep 21, 2021
@spiffcs spiffcs deleted the remove-executable-logs branch September 21, 2021 14:34
@wagoodman wagoodman added the bug Something isn't working label Sep 23, 2021
spiffcs added a commit that referenced this pull request Sep 30, 2021
@spiffcs
Merge branch 'main' into 460-debian-license-upgrade
0095f69 
* main:
  Add vendor + product known good CPE field values (#517)
  Add SBOM to releases (#500)
  Add announcement for KubeCon meetup (#515)
  Prevent invalid CPE field values (#514)
  Filter out CPE product candidates that are asterisks (#513)
  Use Anchore fork of packageurl lib without replace directive (#512)
  update log file permissions to 0644 (#511)

Signed-off-by: Christopher Angelo Phillips <christopher.phillips@anchore.com>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@spiffcs
update log file permissions to 0644 (anchore#511)
62ca6dc 
Signed-off-by: Christopher Angelo Phillips <christopher.phillips@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzantow kzantow kzantow approved these changes

@luhring luhring luhring approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spiffcs @kzantow @luhring @wagoodman