Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loop fixes #1

Merged
merged 5 commits into from
Feb 1, 2017
Merged

Loop fixes #1

merged 5 commits into from
Feb 1, 2017

Conversation

hellysmile
Copy link
Contributor

@hellysmile hellysmile commented Feb 1, 2017 •
edited
Loading

  1. There is no need to pass explicit loop, it can be found in MainThread

  2. swap loop.create_task to asyncio.ensure_future (actually same, but works on any Python3.3+ version)

  3. return future for _call_periodically, to have ability to cancel it

  4. fix loop sleep missed statement

@hellysmile hellysmile mentioned this pull request Feb 1, 2017
Closed
and800
and800 reviewed Feb 1, 2017
View reviewed changes
README.rst Show resolved Hide resolved
@and800 and800 merged commit 7233fe8 into and800:master Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@and800 and800 and800 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hellysmile @and800