Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

The app should 're-lock' (require credentials again) #28

Closed
3 tasks done
asmw opened this issue Aug 13, 2017 · 8 comments
Closed
3 tasks done

The app should 're-lock' (require credentials again) #28

asmw opened this issue Aug 13, 2017 · 8 comments

Comments

@asmw
Copy link

asmw commented Aug 13, 2017

I would like it to re-lock and request device credentials again:

  • Immediately after the screen has been locked
  • After a certain time of non-usage (e.g. 60 seconds)
  • Maybe: when exited through the back button
@flocke flocke self-assigned this Aug 14, 2017
@flocke flocke added this to the v0.2.6 milestone Aug 14, 2017
@flocke flocke modified the milestones: v0.3.0, v0.2.6 Aug 16, 2017
@flocke
Copy link
Member

flocke commented Aug 16, 2017

  1. This seems reasonable, I will look into it.
  2. Maybe. I still have to find a good way to detect user inactivity on Android ... anyone who knows how to do this feel free to submit a pull request.
  3. This should already happen. If I exit my app with the back button and switch back to it it will ask for authentication again.

@asmw
Copy link
Author

asmw commented Aug 16, 2017

Indeed, 3 seems to work. I probably pressed the menu button.

@flocke
Copy link
Member

flocke commented Aug 25, 2017

I just implemented 1, it will be included in the next release.

@asmw
Copy link
Author

asmw commented Aug 25, 2017

Awesome! Thanks for your work.

@flocke flocke added the security label Oct 5, 2017
@icetbr
Copy link

icetbr commented Mar 23, 2018

I bet you never saw this coming but, can we have 1 as an option? About once a month I go on a maintenance spree, using 2FA ~20 times in a row. So I have to unlock the app a lot!

@flocke
Copy link
Member

flocke commented Mar 23, 2018

Sure, I had the idea already to make it optional. Just never had time to implement it.

@flocke flocke added this to the v0.5.1 milestone Mar 23, 2018
flocke added a commit that referenced this issue Mar 28, 2018
@flocke
Copy link
Member

flocke commented Mar 28, 2018

@icetbr Just implemented it, will be in the next version.

@flocke
Copy link
Member

flocke commented Feb 3, 2020

The last point (re-lock after inactivity) was just implemented in #390 🎉

@flocke flocke closed this as completed Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants