Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: YouTube crashes when opened with latest patch #394

Closed
5 tasks done
BAXSD opened this issue Apr 28, 2024 · 36 comments
Closed
5 tasks done

bug: YouTube crashes when opened with latest patch #394

BAXSD opened this issue Apr 28, 2024 · 36 comments
Labels
Bug report Something isn't working

Comments

@BAXSD
Copy link

BAXSD commented Apr 28, 2024

Type

Other

Tools used

RVX Manager

Application

YouTube v19.16.38

Bug description

After patching is done and installed successfully opening YouTube app it crashes. I never make it into the YouTube app. I read on Reddit that someone tested to uncheck "Return YouTube Dislike" and got it to work. I tested that but opening YouTube would only last for a couple of seconds before it crashes again. Have tested with other YouTube versions too but it crashes too. It is something with the latest patch that might cause this. I dont know. Anyone else experiencing the same? How to fix this?

I have tested to reinstall GMSCore, ReVanced Manager and YouTube from scratch but did not help either.

Anddea, Please address this issue and fix this. I would really appreciate it. Im not the only one that having this issue. Thanks in advance :)

Error logs

No response

Solution

No response

Additional context

No response

Device Environment

Android 14

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@BAXSD BAXSD added the Bug report Something isn't working label Apr 28, 2024
@tyw7
Copy link

tyw7 commented Apr 28, 2024

Screenshot_20240428_163428_ReVanced Manager

Hi. These are the patches I used and so far it's not crashing. @BAXSD could you try my patch selection and see if it works for you? At the very least you could get the Adblock and Sponsorblock feature.

I use Revanced manager.

I was the Redditor that reported the crashing here: https://www.reddit.com/r/revancedextended/comments/1cf4pan/one_of_the_patches_keep_crashing/

I have been stung by random patches causing crashes, so I have only opted to patches I will use, keeping the patch number low.

@anddea
Copy link
Owner

anddea commented Apr 28, 2024

Download logcat app, capture and share crash error (search YouTube in the logcat app logs and when you see red, copy and share it here).

@BAXSD
Copy link
Author

BAXSD commented Apr 28, 2024

Download logcat app, capture and share crash error (search YouTube in the logcat app logs and when you see red, copy and share it here).

Thanks for the quick respond. I have never came across "logcat" app or even know what it is. Could you please add a link where I can download it? I searched on Google Play Store and there some options. Dont know exactly which one to download? It must be free.

@tyw7
Copy link

tyw7 commented Apr 28, 2024

YouTube doesn't appear in it, though.

Patch used:
Screenshot_20240428_181656_ReVanced Manager

To help you diagnose, I am going to attach the APK too. To others, DO NOT trust random Revanced patched APKs.

APK (expires in 7 days): https://we.tl/t-WJCd296DVL

Log_2024-04-28_18-01-22.txt
2024-04-28_18.02.zip

@tyw7
Copy link

tyw7 commented Apr 28, 2024

Download logcat app, capture and share crash error (search YouTube in the logcat app logs and when you see red, copy and share it here).

Thanks for the quick respond. I have never came across "logcat" app or even know what it is. Could you please add a link where I can download it? I searched on Google Play Store and there some options. Dont know exactly which one to download? It must be free.

I used https://play.google.com/store/apps/details?id=scd.lcex&hl=en_US

Maybe attach your Patched app to help @anddea diagnose it on their end?

Also, what patches are you using?

@anddea
Copy link
Owner

anddea commented Apr 28, 2024

I use all patches and can't reproduce it.

https://play.google.com/store/apps/details?id=com.dp.logcatapp

I think any logcat will do. Just start it before you open YT.

@tyw7
Copy link

tyw7 commented Apr 28, 2024

I use all patches and can't reproduce it.

https://play.google.com/store/apps/details?id=com.dp.logcatapp

I think any logcat will do. Just start it before you open YT.

I don't see YouTube in the logs though. To help you, I have attached the apk. And the Core I'm using is https://github.com/ReVanced/GmsCore/releases

Edit: There are other people reporting crashes too.

@anddea
Copy link
Owner

anddea commented Apr 28, 2024

What is the package name of your YouTube app?

What patch version do you use?

@tyw7
Copy link

tyw7 commented Apr 28, 2024

What is the package name of your YouTube app?

What patch version do you use?

See #394 (comment). From the working one, the patch version is 2.224.0, 0.151.1-dev-3.

Using the APK from https://www.apkmirror.com/apk/google-inc/youtube/youtube-19-16-38-release/youtube-19-16-38-android-apk-download/

@anddea
Copy link
Owner

anddea commented Apr 28, 2024

Update to latest dev patches 2.224.1-dev-5. you use dev integrations that is incompatible with stable patches.

@tyw7
Copy link

tyw7 commented Apr 28, 2024

Update to latest dev patches 2.224.1-dev-5. you use dev integrations that is incompatible with stable patches.

Unfortunately Revanced Manager can't exclude dev integrations, at least I can't find within the options.

@tyw7
Copy link

tyw7 commented Apr 28, 2024

This is the changelog of the patch used, according to the Revanced manager. This may help to recognize which patch it belongs to:
Screenshot_20240428_191852_ReVanced Manager

The Revanced about screen:
Screenshot_20240428_192133_ReVanced Extended

@tyw7
Copy link

tyw7 commented Apr 28, 2024

Update to latest dev patches 2.224.1-dev-5. you use dev integrations that is incompatible with stable patches.

Can you push Dev 5 to stable so I can see if I can fetch it?

@BAXSD
Copy link
Author

BAXSD commented Apr 28, 2024

I use all patches and can't reproduce it.

https://play.google.com/store/apps/details?id=com.dp.logcatapp

I think any logcat will do. Just start it before you open YT.

That app was too old for my device and could not download it. I downloaded Logcat Extreme in the link under. I pressed record and opened Youtube. Then opened the Logcat Extreme and stopped the recording and went to the log it recorded but I cant find anything related to Youtube when I searched. Have I done it right or how should I do?

https://play.google.com/store/apps/details?id=scd.lcex&hl=sv&gl=US

@BAXSD
Copy link
Author

BAXSD commented Apr 28, 2024

Download logcat app, capture and share crash error (search YouTube in the logcat app logs and when you see red, copy and share it here).

Thanks for the quick respond. I have never came across "logcat" app or even know what it is. Could you please add a link where I can download it? I searched on Google Play Store and there some options. Dont know exactly which one to download? It must be free.

I used https://play.google.com/store/apps/details?id=scd.lcex&hl=en_US

Maybe attach your Patched app to help @anddea diagnose it on their end?

Also, what patches are you using?

How do you use that app Logcat Extreme? I press record the open Youtube then back to Logcat and stop recording but I cant find anything related to Youtube in the log. What am I doing wrong. Do I need root?

@tyw7
Copy link

tyw7 commented Apr 28, 2024

Download logcat app, capture and share crash error (search YouTube in the logcat app logs and when you see red, copy and share it here).

Thanks for the quick respond. I have never came across "logcat" app or even know what it is. Could you please add a link where I can download it? I searched on Google Play Store and there some options. Dont know exactly which one to download? It must be free.

I used https://play.google.com/store/apps/details?id=scd.lcex&hl=en_US
Maybe attach your Patched app to help @anddea diagnose it on their end?
Also, what patches are you using?

How do you use that app Logcat Extreme? I press record the open Youtube then back to Logcat and stop recording but I cant find anything related to Youtube in the log. What am I doing wrong. Do I need root?

I don't know either. I, too, don't see anything related to YouTube in the log. That's why I uploaded the patched APK as well so @anddea can dissect it themselves.

@anddea
Copy link
Owner

anddea commented Apr 28, 2024

Use RVX Manager. It should be a bug of ReVanced Manager that it shows dev integrations for stable patches.

https://github.com/inotia00/revanced-manager/releases

@BAXSD
Copy link
Author

BAXSD commented Apr 28, 2024

Use RVX Manager. It should be a bug of ReVanced Manager that it shows dev integrations for stable patches.

https://github.com/inotia00/revanced-manager/releases

Im using ReVanced Manager too. Does that affect my issue too? Should I change to RVX Manager too? Should I change source to anddea in RVX Manager instead of default inotia00?

@tyw7
Copy link

tyw7 commented Apr 28, 2024

Use RVX Manager. It should be a bug of Manager that it it shows dev integrations for stable patches.

https://github.com/inotia00/revanced-manager/releases

"Bug" reported: ReVanced/revanced-manager#1887

@tyw7
Copy link

tyw7 commented Apr 28, 2024

@anddea Inotia's patch is pulling in Dev5 though.

Screenshot_20240428_195619_ReVanced Extended

@BAXSD
Copy link
Author

BAXSD commented Apr 28, 2024

@anddea Inotia's patch is pulling in Dev5 though.

Screenshot_20240428_195619_ReVanced Extended

It dont crash now when I used RVX Manager. Should I not use RVX Manager? What the downside using Dev patches?

@tyw7
Copy link

tyw7 commented Apr 28, 2024

@anddea Inotia's patch is pulling in Dev5 though.
Screenshot_20240428_195619_ReVanced Extended

It dont crash now when I used RVX Manager. Should I not use RVX Manager? What the downside using Dev patches?

No idea. I thought that patches with the word "dev" in front aren't ready for prime time ie dev build vs stable build but Anddea might be using a different naming scheme.

@anddea
Copy link
Owner

anddea commented Apr 28, 2024

Dev is mostly stable too, but it's better to test dev and if something's broken then fix it until it goes stable.

Currently, the problem is that you wanted to use stable where patches are stable actually but integrations are not which causes crash as they are incompatible.

Yes, change sources to anddea to use these patches and integrations.

@tyw7
Copy link

tyw7 commented Apr 28, 2024

Dev is mostly stable too, but it's better to test dev and if something's broken then fix it until it goes stable.

Currently, the problem is that you wanted to use stable where patches are stable actually but integrations are not which causes crash as they are incompatible.

Yes, change sources to anddea to use these patches and integrations.

Can you try to diagnose the problem with Revanced Manager and maybe post a detailed diagnosis so the devs of that app can fix it?

Even Inotia's manager is pulling in a dev build for both patches and integrations.

@selfmusing
Copy link

What's the exact issue you guys are facing now?

@tyw7
Copy link

tyw7 commented Apr 28, 2024

Apparently, both Inotia's and Revanced Manager pull in the dev version of the integrations. Inotia Manager pulls in the dev patches as well, but the Revanced Manager only pulls in the stable patches.

And @anddea says the crash could be caused by a mismatch between stable patches and dev integration. Inotia's version kinda fixes this by using both dev patches and dev integration, but don't think this is the intended behavior.

@selfmusing
Copy link

Apparently, both Inotia's and Revanced Manager pull in the dev version of the integrations. Inotia Manager pulls in the dev patches as well, but the Revanced Manager only pulls in the stable patches.

And @anddea says the crash could be caused by a mismatch between stable patches and dev integration. Inotia's version kinda fixes this by using both dev patches and dev integration, but don't think this is the intended behavior.

Try this fork of rvx manager : https://github.com/Francesco146/revanced-manager

It even has a toggle to enable or disable pre-release patches .

IMG_20240429_012949_596

@selfmusing
Copy link

Dev is mostly stable too, but it's better to test dev and if something's broken then fix it until it goes stable.

Currently, the problem is that you wanted to use stable where patches are stable actually but integrations are not which causes crash as they are incompatible.

Yes, change sources to anddea to use these patches and integrations.

Btw , I've tried the latest dev patches.
YT doesn't crash for me anymore with append timestamp.
But it's crashing for some users to whom i gave the same patched.apk for testing.

💀 Unfortunately , I haven't got any logs from any of them ...

@anddea
Copy link
Owner

anddea commented Apr 28, 2024

but don't think this is the intended behavior.

For RVX Manager, it's intended behavior. Dev releases have always been enabled there.

But it's crashing for some users to whom i gave the same patched.apk for testing.

Maybe they have to clear their cache and data.

@anddea anddea closed this as completed Apr 28, 2024
@anddea
Copy link
Owner

anddea commented Apr 28, 2024

Just to notify you, the bug of the ReVanced Manager is fixed now.

@tyw7
Copy link

tyw7 commented Apr 28, 2024

Even without a new version being pushed?

@anddea
Copy link
Owner

anddea commented Apr 28, 2024

You need to use the latest dev release of ReVanced Manager.

https://github.com/ReVanced/revanced-manager/releases/tag/v1.21.0-dev.2

And everything after it should work as well.

@BAXSD
Copy link
Author

BAXSD commented Apr 29, 2024

@anddea

What Manager do you recommend? ReVanced Manager or RVX Manager? Will you maintain and update RVX Manager too? Does RVX Manager fetch Dev or Stable releases? Whats your overall recommendation? I just want an option that works without similar issue in this topic.

@anddea
Copy link
Owner

anddea commented Apr 29, 2024

RVX Manager fetches dev releases, but they are stable most of the time. So tbh I have no recommendations here. This bug was unknown until now and when we faced this issue, fixed it immediately.

I think there's no need for me to maintain the Manager, at least for now.

@selfmusing
Copy link

Apparently, both Inotia's and Revanced Manager pull in the dev version of the integrations. Inotia Manager pulls in the dev patches as well, but the Revanced Manager only pulls in the stable patches.
And @anddea says the crash could be caused by a mismatch between stable patches and dev integration. Inotia's version kinda fixes this by using both dev patches and dev integration, but don't think this is the intended behavior.

Try this fork of rvx manager : https://github.com/Francesco146/revanced-manager

It even has a toggle to enable or disable pre-release patches .

IMG_20240429_012949_596

have you tried this @BAXSD ?

@BAXSD
Copy link
Author

BAXSD commented Apr 29, 2024

Apparently, both Inotia's and Revanced Manager pull in the dev version of the integrations. Inotia Manager pulls in the dev patches as well, but the Revanced Manager only pulls in the stable patches.
And @anddea says the crash could be caused by a mismatch between stable patches and dev integration. Inotia's version kinda fixes this by using both dev patches and dev integration, but don't think this is the intended behavior.

Try this fork of rvx manager : https://github.com/Francesco146/revanced-manager
It even has a toggle to enable or disable pre-release patches .
IMG_20240429_012949_596

have you tried this @BAXSD ?

No I have not. I went with RVX Manager and it solved my issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants