#164069240 view edit history of comment #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasibani-roy
requested review from
joelethan,
BagzieGracious,
CryceTruly,
marthamareal and
Peace-Apple
wasibani-roy
force-pushed
the
ft-track-comment-history-164069240
branch
from
15a636b
to
b17a6d1
Compare
CryceTruly
suggested changes
Mar 21, 2019
| self.assertEqual(response.status_code, status.HTTP_404_NOT_FOUND) | ||
| self.assertIn("Not found", response.data["detail"]) | ||
|
|
||
| # def test_update_a_comment_not_yours(self): |
There was a problem hiding this comment.
Hey @wasibani-roy, I realize you have commented code,you could consider refactoring.
wasibani-roy
force-pushed
the
ft-track-comment-history-164069240
branch
from
b17a6d1
to
41e6bbe
Compare
BagzieGracious
previously approved these changes
Mar 21, 2019
CryceTruly
previously approved these changes
Mar 21, 2019
- Ensure that authenticated users can view edit history of their comments [Starts #164069240]
wasibani-roy
dismissed stale reviews from CryceTruly and BagzieGracious
via
cf655fe
wasibani-roy
force-pushed
the
ft-track-comment-history-164069240
branch
from
41e6bbe
to
cf655fe
Compare
|
Code Climate has analyzed commit cf655fe and detected 0 issues on this pull request. View more on Code Climate. |
BagzieGracious
approved these changes
Mar 21, 2019
joelethan
approved these changes
Mar 21, 2019
Peace-Apple
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables a user of a comment view edits made to a comment on a given article
Description of Task to be completed?
Ensure authenticated user can view edit history of there comment
How should this be manually tested?
Clone the repo and cd into Ah-backend-aquaman
git checkout ft-track-comment-history-164069240
pip install -r requirements.txt
python manage.py makemigrations
python manage.py migrate
python manage.py runserver
Register and then login into the system
The below endpoint will be used to view your edit history
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#164069240
Screenshot
Retrieve edit history
