#158457052 User should be able to upload profile picture on signup #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 420
💛 - Coveralls |
bekomay26
force-pushed
the
ft-upload-image-signup-158457052
branch
from
b9d0074
to
cd0a05e
Compare
bekomay26
force-pushed
the
ft-upload-image-signup-158457052
branch
from
cd0a05e
to
08d0f71
Compare
bekomay26
force-pushed
the
ft-upload-image-signup-158457052
branch
from
08d0f71
to
b30d35c
Compare
houndci-bot
reviewed
Jul 19, 2018
public/js/controllers/auth.js
Outdated
| localStorage.setItem('username', response.name); | ||
| $location.path('/'); | ||
| }, (error) => { | ||
| console.log(error); |
There was a problem hiding this comment.
Unexpected console statement no-console
public/js/controllers/auth.js
Outdated
| localStorage.setItem('username', response.name); | ||
| $location.path('/'); | ||
| }, (error) => { | ||
| console.log(error); |
There was a problem hiding this comment.
Unexpected console statement no-console
| $scope.viewImage = function () { | ||
| const file = event.target.files[0]; | ||
| if (file) { | ||
| const fileReader = new FileReader(); |
There was a problem hiding this comment.
'FileReader' is not defined no-undef
| }; | ||
| $scope.imagePreview = ''; | ||
| $scope.viewImage = function () { | ||
| const file = event.target.files[0]; |
There was a problem hiding this comment.
Unexpected use of 'event' no-restricted-globals
'event' is not defined no-undef
bekomay26
changed the title
- Redesign avatar modal - Upload image to cloudinary - Test the upload function - edit build and compile gulp tasks [Finishes #158457052]
bekomay26
force-pushed
the
ft-upload-image-signup-158457052
branch
from
b30d35c
to
8854942
Compare
houndci-bot
reviewed
Jul 19, 2018
| }; | ||
| $scope.imagePreview = ''; | ||
| $scope.viewImage = function () { | ||
| const file = event.target.files[0]; |
There was a problem hiding this comment.
Unexpected use of 'event' no-restricted-globals
'event' is not defined no-undef
bekomay26
changed the title
adetola-ralph
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
As a new user, I should be able to upload my desired profile image on signup
How should this be manually tested?
Clone the repo. Run ’npm install’ and run ’npm start’. Visit ‘http://localhost:3000/#!/signup’ and click on ‘upload profile picture’
What are the relevant pivotal tracker stories?
#158457052
Any background context you want to add?
Screenshots