#158457035 Implement Jwt on signup #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hasstrup
changed the title
Hasstrup
changed the title
Hasstrup
force-pushed
the
ft-jwt-on-signup-158457035
branch
2 times, most recently
from
0bc1ff7
to
5c3ea0c
Compare
- Implements receipt of jwt token on signup - Implements correct controller on signup/login page - Implements caching of data in browser [Finishes #158457035]
Hasstrup
force-pushed
the
ft-jwt-on-signup-158457035
branch
from
5c3ea0c
to
bc9f620
Compare
Hasstrup
changed the title
- Implements receipt of jwt token on signup - Implements correct controller on signup/login page - Implements caching of data in browser [Finishes #158457035]
Pull Request Test Coverage Report for Build 132
💛 - Coveralls |
Hasstrup
force-pushed
the
ft-jwt-on-signup-158457035
branch
from
b85d082
to
cfa166e
Compare
…a/ET-cfh into ft-jwt-on-signup-158457035
Hasstrup
force-pushed
the
ft-jwt-on-signup-158457035
branch
from
cfa166e
to
6e09097
Compare
added 2 commits
July 10, 2018 07:11
adetola-ralph
approved these changes
Jul 10, 2018
karma.conf.js
Outdated
|
|
||
| // start these browsers | ||
| // available browser launchers: https://npmjs.org/browse/keyword/karma-launcher | ||
| browsers: ['ChromeHeadless'], | ||
| browsers: ['Chrome'], |
There was a problem hiding this comment.
Remove unused and commented out code
karma.conf.js
Outdated
| @@ -40,20 +43,24 @@ module.exports = (config) => { | |||
| // possible values: config.LOG_DISABLE || config.LOG_ERROR || config.LOG_WARN || config.LOG_INFO || config.LOG_DEBUG | |||
| logLevel: config.LOG_INFO, | |||
|
|
|||
| // enable / disable watching file and executing tests whenever any file changes | |||
| autoWatch: true, | |||
| // // enable / disable watching file and executing tests whenever any file changes | |||
There was a problem hiding this comment.
Remove the extra comment slashed
public/js/navbar.js
Outdated
| @@ -1 +1 @@ | |||
| $('.dropdown-trigger').dropdown(); | |||
| // $('.dropdown-trigger').dropdown(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This Pull Request integrates the jwt on signup feature.
Description of Task to be completed?
Users once authenticated via the signup api should be returned a JWT to be required on subsequent call to all other endpoints that require authentication.
[ Extract from PT board]
What are the relevant pivotal tracker stories?
#158457035 Users should receive a JWT on successful signup
How should this be manually tested?
Clone into local system, install dependencies and run npm start.
using postman or any other api interactor,
send a json object containing, email , password, name fields to '/api/auth/signup'.
Test cases also reflect changes in this PR
Any background context you want to add?
I also changed the sign up and log in form actions to integrate fully with the api
Screenshots
None