-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#158457035 Implement Jwt on signup #7
Conversation
0bc1ff7
to
5c3ea0c
Compare
- Implements receipt of jwt token on signup - Implements correct controller on signup/login page - Implements caching of data in browser [Finishes #158457035]
5c3ea0c
to
bc9f620
Compare
- Implements receipt of jwt token on signup - Implements correct controller on signup/login page - Implements caching of data in browser [Finishes #158457035]
Pull Request Test Coverage Report for Build 132
💛 - Coveralls |
b85d082
to
cfa166e
Compare
…a/ET-cfh into ft-jwt-on-signup-158457035
cfa166e
to
6e09097
Compare
karma.conf.js
Outdated
|
||
// start these browsers | ||
// available browser launchers: https://npmjs.org/browse/keyword/karma-launcher | ||
browsers: ['ChromeHeadless'], | ||
browsers: ['Chrome'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unused and commented out code
karma.conf.js
Outdated
@@ -40,20 +43,24 @@ module.exports = (config) => { | |||
// possible values: config.LOG_DISABLE || config.LOG_ERROR || config.LOG_WARN || config.LOG_INFO || config.LOG_DEBUG | |||
logLevel: config.LOG_INFO, | |||
|
|||
// enable / disable watching file and executing tests whenever any file changes | |||
autoWatch: true, | |||
// // enable / disable watching file and executing tests whenever any file changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the extra comment slashed
public/js/navbar.js
Outdated
@@ -1 +1 @@ | |||
$('.dropdown-trigger').dropdown(); | |||
// $('.dropdown-trigger').dropdown(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unused code
What does this PR do?
This Pull Request integrates the jwt on signup feature.
Description of Task to be completed?
Users once authenticated via the signup api should be returned a JWT to be required on subsequent call to all other endpoints that require authentication.
[ Extract from PT board]
What are the relevant pivotal tracker stories?
#158457035 Users should receive a JWT on successful signup
How should this be manually tested?
Clone into local system, install dependencies and run npm start.
using postman or any other api interactor,
send a json object containing, email , password, name fields to '/api/auth/signup'.
Test cases also reflect changes in this PR
Any background context you want to add?
I also changed the sign up and log in form actions to integrate fully with the api
Screenshots
None