Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#165273489 Add article readtime feature #32

Merged
merged 1 commit into from
May 9, 2019
Merged

#165273489 Add article readtime feature #32

merged 1 commit into from
May 9, 2019

Conversation

sanya-kenneth
Copy link
Contributor

What does this PR do?

  • Add calculate read time functionality
  • Add interprete read time functionality
  • Integrate read time calculator with articles app

How to test this.

  • Create an article
  • Check for read_time in the response body

[POST] /api/articles/

Request body

{
    "title": "Fresh kid wonders on stage at lugogo",
    "description": "he wows the kids",
    "body": "Fresh kid is a 5 year musician who has been on map.",
            "author": "jean",
            "tagList": []
}

Response body

{
    "article": {
        "article": {
            "id": 33,
            "title": "Fresh kid wonders on stage at lugogo",
            "description": "he wows the kids",
            "body": "Fresh kid is a 5 year musician who has been on map.",
            "slug": "fresh-kid-wonders-on-stage-at-lugogo",
            "created_at": "2019-05-09T08:07:40.889971Z",
            "updated_at": "2019-05-09T08:07:40.889999Z",
            "likes_count": 0,
            "dislikes_count": 0,
            "favorited": false,
            "favorite_count": 0,
            "read_time": "less than a minute read",
            "tagList": [],
            "author": "adminee"
        }
    }
}

Relevant PT stories

#165273489

@joelmugaya joelmugaya temporarily deployed to inviticus-staging-pr-32 May 9, 2019 08:14 Inactive
KabohaJeanMark
KabohaJeanMark approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@KabohaJeanMark KabohaJeanMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I have tested it out on local and it is working fine. Good work on the logic Sanya.

joelmugaya
joelmugaya approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@joelmugaya joelmugaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good work

@sanya-kenneth sanya-kenneth force-pushed the ft-article-readtime-165273489 branch from ee9844d to 452fa17 Compare May 9, 2019 08:53
engjames
engjames approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@engjames engjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sanya-kenneth nice work

@sanya-kenneth sanya-kenneth temporarily deployed to inviticus-staging-pr-32 May 9, 2019 08:53 Inactive
@sanya-kenneth
ft(article-readtime): Add article readtime feature
d21b97e 
- Add calculate readtime functionality
- Add interprete readtime functionality

[#165273489]
@sanya-kenneth sanya-kenneth force-pushed the ft-article-readtime-165273489 branch from 452fa17 to d21b97e Compare May 9, 2019 09:35
mwinel
mwinel approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@mwinel mwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

archibishop
archibishop approved these changes May 9, 2019
View reviewed changes
Copy link

@archibishop archibishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanya-kenneth LGTM i am merging this.

@archibishop archibishop merged commit 6614de1 into develop May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwinel mwinel mwinel approved these changes

@archibishop archibishop archibishop approved these changes

@3Nakajugo 3Nakajugo 3Nakajugo approved these changes

@engjames engjames engjames approved these changes

@KabohaJeanMark KabohaJeanMark KabohaJeanMark approved these changes

@joelmugaya joelmugaya joelmugaya approved these changes

Assignees
No one assigned
Labels
Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sanya-kenneth @mwinel @archibishop @3Nakajugo @engjames @KabohaJeanMark @joelmugaya