Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#160617682 pagination support for articles #25

Merged
merged 1 commit into from
Oct 12, 2018
Merged

#160617682 pagination support for articles #25

merged 1 commit into from
Oct 12, 2018

Conversation

AmosWels
Copy link
Contributor

What does this PR do?

  • Enable pagination support for the articles so that reading is not a nightmare for readers when there are so many articles.

Description of Task to be completed?

  • When a user wants to views articles, they can view paginated articles

How should this be manually tested?

  • Viewing all articles by accessing this endpoint at /api/articles/ in postman

Screenshots

  • view all paginated articles
    image

What are the relevant pivotal tracker stories?

  • #160617682

@nakiwuge nakiwuge temporarily deployed to ah-backend-lannister-sta-pr-25 October 11, 2018 18:40 Inactive
@coveralls
Copy link

coveralls commented Oct 11, 2018 •
edited

Coverage Status

Coverage decreased (-0.005%) to 96.276% when pulling f64cb6a on ft-paginate-articles-160617682 into e869070 on develop.

@AmosWels AmosWels added the ready PR is ready for merging label Oct 11, 2018
@AmosWels AmosWels force-pushed the ft-paginate-articles-160617682 branch from 04dafd1 to 442feba Compare October 12, 2018 07:13
@kimbugp kimbugp temporarily deployed to ah-backend-lannister-sta-pr-25 October 12, 2018 07:13 Inactive
@AmosWels AmosWels force-pushed the ft-paginate-articles-160617682 branch from 442feba to 1933d71 Compare October 12, 2018 07:16
@kimbugp kimbugp temporarily deployed to ah-backend-lannister-sta-pr-25 October 12, 2018 07:16 Inactive
@AmosWels AmosWels force-pushed the ft-paginate-articles-160617682 branch from 1933d71 to 588047f Compare October 12, 2018 09:07
@kimbugp kimbugp temporarily deployed to ah-backend-lannister-sta-pr-25 October 12, 2018 09:07 Inactive
@AmosWels AmosWels force-pushed the ft-paginate-articles-160617682 branch from 588047f to f8fd780 Compare October 12, 2018 09:26
@kimbugp kimbugp temporarily deployed to ah-backend-lannister-sta-pr-25 October 12, 2018 09:26 Inactive
@AmosWels AmosWels force-pushed the ft-paginate-articles-160617682 branch from f8fd780 to 2f7c993 Compare October 12, 2018 09:31
@kimbugp kimbugp temporarily deployed to ah-backend-lannister-sta-pr-25 October 12, 2018 09:31 Inactive
@AmosWels AmosWels force-pushed the ft-paginate-articles-160617682 branch from 2f7c993 to 09f0fa9 Compare October 12, 2018 09:44
@kimbugp kimbugp temporarily deployed to ah-backend-lannister-sta-pr-25 October 12, 2018 09:44 Inactive
@AmosWels AmosWels force-pushed the ft-paginate-articles-160617682 branch from 09f0fa9 to a2fd79f Compare October 12, 2018 09:56
@kimbugp kimbugp temporarily deployed to ah-backend-lannister-sta-pr-25 October 12, 2018 09:57 Inactive
@AmosWels AmosWels force-pushed the ft-paginate-articles-160617682 branch from a2fd79f to 859c754 Compare October 12, 2018 12:31
@nakiwuge nakiwuge temporarily deployed to ah-backend-lannister-sta-pr-25 October 12, 2018 12:31 Inactive
@AmosWels
ft(upgrade):pagination support for articles
f64cb6a 
- add function in list all views to paginate articles
- import paginator from django framework

[DELIVERS #160617682]

ft(maintain):add a defaults pagination class to settings
@AmosWels AmosWels force-pushed the ft-paginate-articles-160617682 branch from 859c754 to f64cb6a Compare October 12, 2018 14:07
@PatrickCmd PatrickCmd merged commit b57c200 into develop Oct 12, 2018
@PatrickCmd PatrickCmd deleted the ft-paginate-articles-160617682 branch October 17, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickCmd PatrickCmd PatrickCmd approved these changes

@nakiwuge nakiwuge Awaiting requested review from nakiwuge

@kimbugp kimbugp Awaiting requested review from kimbugp

@zaabu zaabu Awaiting requested review from zaabu

@kcharles52 kcharles52 Awaiting requested review from kcharles52

Assignees
No one assigned
Labels
ready PR is ready for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AmosWels @coveralls @PatrickCmd @nakiwuge @kimbugp