-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
161255361 comment on an article #23
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new folder in apps articles/ [Feature #161255358]
- Add new folder in apps articles/ [Feature #161255358]
- Add new folder in apps articles/ [Feature #161255358]
- Add new folder in apps articles/ [Feature #161255358]
…codeofduty into ft-articles-161255358
- Add models for articles - Add seriaizers for articles - Add views for articles - Add url routes for articles [Feature #161255358]
- User can create an article - User can fetch all articles - User can fetch a single article - User can update their article - User can delete their article - Add tests for all the CRUD functions [Feature #161255358]
- Add new folder in apps articles/ [Feature #161255358]
- Add new folder in apps articles/ [Feature #161255358]
- Add models for articles - Add seriaizers for articles - Add views for articles - Add url routes for articles [Feature #161255358]
- User can create an article - User can fetch all articles - User can fetch a single article - User can update their article - User can delete their article - Add tests for all the CRUD functions [Feature #161255358]
- Rebase from develop and merge conflicts [Feature #161255358]
- Merge conflicts from origin [Feature #161255358]
- Merge conflicts from origin [Feature #161255358]
- add .env variables - add 2 endpoints api/users/reset-password an api/users/forget-password - ensure reset link is sent to user's email - ensure user can reset password using that link - add .env.example [Feature #161255355] * Feature(Reset Password): Add Reset Password Endpoint dquote> - Update APIView to CreateAPIView dquote> - update requuirements.txt dquote> [Feature #161255355] * Feature(Reset Password): Add Reset Password Endpoint dquote> - Update APIView to CreateAPIView dquote> - update requuirements.txt dquote> [Feature #161255355] * Feature(Reset password): Update requirements.txt - add django-rest-swagger to requirements.txt [Feature #161255355] * Feauture(Reset Password): Add Reset Password Endpoint - add .env variables - add 2 endpoints api/users/reset-password an api/users/forget-password - ensure reset link is sent to user's email - ensure user can reset password using that link - add .env.example [Feature #161255355] * Feature(Reset Password): Add Reset Password Endpoint dquote> - Update APIView to CreateAPIView dquote> - update requuirements.txt dquote> [Feature #161255355] * Feature(Reset Password): Add Reset Password Endpoint dquote> - Update APIView to CreateAPIView dquote> - update requuirements.txt dquote> [Feature #161255355] * Feature(Reset password): Update requirements.txt - add django-rest-swagger to requirements.txt [Feature #161255355] * Feature(Reset Password): Add template forms - Add html template forms for forgot password and reset password - Add get methods to route to the templates - Use EmailMultiAlternatives in place of send_mail to send html content [Feature #161255355] * Feature(Reset Password): Fix merge conflict - Add library imports to fix merge conflict [Feature #161255355] * Feature(Reset Password): Use JWT token for encoding - Use jwt token in addition to default_token_generator to reset password [Feature #161255355] * Feature(Reset Password): Add unittests for reset password - Add unittests for forgot password - Add unittests for reset password - Tests cover both sad and happy events [Feature #161255355] * Feature(Reset Password): Update requirements.txt - Update requirements.txt [Feature #161255355] * Feature(Reset Password): Update templates - Adjust css and html on email template [Feature #161255355] * Feature(Reset Password): Update test_reset_password.py - Remove redundant imports [Feature #161255355] * Feauture(Reset Password): Add Reset Password Endpoint - add .env variables - add 2 endpoints api/users/reset-password an api/users/forget-password - ensure reset link is sent to user's email - ensure user can reset password using that link - add .env.example [Feature #161255355] * Feature(Reset Password): Add Reset Password Endpoint dquote> - Update APIView to CreateAPIView dquote> - update requuirements.txt dquote> [Feature #161255355] * Feature(Reset Password): Add Reset Password Endpoint dquote> - Update APIView to CreateAPIView dquote> - update requuirements.txt dquote> [Feature #161255355] * Feature(Reset password): Update requirements.txt - add django-rest-swagger to requirements.txt [Feature #161255355] * Feauture(Reset Password): Add Reset Password Endpoint - add .env variables - add 2 endpoints api/users/reset-password an api/users/forget-password - ensure reset link is sent to user's email - ensure user can reset password using that link - add .env.example [Feature #161255355] * Feature(Reset Password): Add Reset Password Endpoint dquote> - Update APIView to CreateAPIView dquote> - update requuirements.txt dquote> [Feature #161255355] * Feature(Reset Password): Add Reset Password Endpoint dquote> - Update APIView to CreateAPIView dquote> - update requuirements.txt dquote> [Feature #161255355] * Feature(Reset password): Update requirements.txt - add django-rest-swagger to requirements.txt [Feature #161255355] * Feature(Reset Password): Add template forms - Add html template forms for forgot password and reset password - Add get methods to route to the templates - Use EmailMultiAlternatives in place of send_mail to send html content [Feature #161255355] * Feature(Reset Password): Use JWT token for encoding - Use jwt token in addition to default_token_generator to reset password [Feature #161255355] * Feature(Reset Password): Add unittests for reset password - Add unittests for forgot password - Add unittests for reset password - Tests cover both sad and happy events [Feature #161255355] * Feature(Reset Password): Update templates - Adjust css and html on email template [Feature #161255355] * Feature(Reset Password): Update test_reset_password.py - Remove redundant imports [Feature #161255355] * Feature(Reset password): User Reset Password via email - remove redundant imports in tests - remove unnecessary comments [Feature #161255355] * Feature(Reset password): Add unittests - Add test for email verification after signup [Feature #161255355]
- Model for user profile - User relation migrations - Serializer to user profile inputs [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Model for user profile - User relation migrations - Serializer to user profile inputs [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - GET, PUT and PATCH view for profile - Add admin.py with credentials - Profile relations migrations - Update serializer [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - update .gitignore [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor failing test assertion error - remove admin.py [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - View all profiles [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Update profile data [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Model for user profile - User relation migrations - Serializer to user profile inputs [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Model for user profile - User relation migrations - Serializer to user profile inputs [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - GET, PUT and PATCH view for profile - Add admin.py with credentials - Profile relations migrations - Update serializer [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - update .gitignore [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - View all profiles [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Fetch all profiles [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Test User profile [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor test [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor test [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor test [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor test [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor test [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor test [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor test [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Model for user profile - User relation migrations - Serializer to user profile inputs [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Model for user profile - User relation migrations - Serializer to user profile inputs [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - GET, PUT and PATCH view for profile - Add admin.py with credentials - Profile relations migrations - Update serializer [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor failing test assertion error - remove admin.py [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Model for user profile - User relation migrations - Serializer to user profile inputs [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Model for user profile - User relation migrations - Serializer to user profile inputs [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - View all profiles [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Fetch all profiles [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Test User profile [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor test [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Model for user profile - User relation migrations - Serializer to user profile inputs [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Model for user profile - User relation migrations - Serializer to user profile inputs [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - GET, PUT and PATCH view for profile - Add admin.py with credentials - Profile relations migrations - Update serializer [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - update .gitignore [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor failing test assertion error - remove admin.py [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - View all profiles [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Update profile data [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Model for user profile - User relation migrations - Serializer to user profile inputs [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Model for user profile - User relation migrations - Serializer to user profile inputs [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor failing test assertion error - remove admin.py [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor test [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Model for user profile - User relation migrations - Serializer to user profile inputs [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Model for user profile - User relation migrations - Serializer to user profile inputs [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - GET, PUT and PATCH view for profile - Add admin.py with credentials - Profile relations migrations - Update serializer [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - View all profiles [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Update profile data [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Model for user profile - User relation migrations - Serializer to user profile inputs [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Model for user profile - User relation migrations - Serializer to user profile inputs [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - GET, PUT and PATCH view for profile - Add admin.py with credentials - Profile relations migrations - Update serializer [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor failing test assertion error - remove admin.py [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Update profile data [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Test User profile [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor test [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor test [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor test [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor test [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor test [Feature #161255357] Feature(User Profile):Users should be able to create their profiles - Refactor test [Feature #161255357]
- Model for comments - Serialiser for comments - views for comments [Feature #161255361]
- write test for comments [Feature ##161255361]
- Modify tests [Feature #161255361]
Pull Request Test Coverage Report for Build 216
💛 - Coveralls |
maxwellgithinji
approved these changes
Nov 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- resolve conflict [Feature #161255361]
njeri-ngigi
approved these changes
Nov 9, 2018
- resolve conflict [Feature #161255361]
maxwellgithinji
approved these changes
Nov 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3N61N33R
approved these changes
Nov 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
Endpoints
What are the relevant pivotal tracker stories?
Screenshots (if appropriate)
Questions: