Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#165819922 Implement Landing Page #11

Merged
merged 1 commit into from
May 10, 2019
Merged

#165819922 Implement Landing Page #11

merged 1 commit into from
May 10, 2019

Conversation

patrickf949
Copy link
Contributor

@patrickf949 patrickf949 commented May 7, 2019 •
edited

What does this PR do?

Implements landing page for Authors Haven

Description of Task to be completed?

  • Edit the landing page to contain buttons for the login and signup
  • Add articles for the backend api
  • Style the landing page according to the mockups

How can this be tested?

Install all dependencies

  • $ npm install

Start the server

  • $ npm start

Checkout the landing page that appears in your browser and click the Sign in button in the top right corner.

Screen shots:

Landing Page

Screenshot 2019-05-10 at 08 21 22

Relevant Pivotal Tracker Stories:

165819922

houndci-bot
houndci-bot reviewed May 7, 2019
View reviewed changes
src/components/home.js Outdated Show resolved Hide resolved
@patrickf949 patrickf949 force-pushed the ft-design-home-page-165819922 branch from 15fe436 to 961b6d5 Compare May 7, 2019 13:16
houndci-bot
houndci-bot reviewed May 7, 2019
View reviewed changes
src/components/home.js Outdated Show resolved Hide resolved
src/components/header.js Outdated Show resolved Hide resolved
src/actions/getArticles.js Outdated Show resolved Hide resolved
@patrickf949 patrickf949 force-pushed the ft-design-home-page-165819922 branch from 961b6d5 to 29f0a57 Compare May 8, 2019 07:38
houndci-bot
houndci-bot reviewed May 8, 2019
View reviewed changes
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
@patrickf949 patrickf949 force-pushed the ft-design-home-page-165819922 branch from 29f0a57 to a9130ae Compare May 8, 2019 08:23
houndci-bot
houndci-bot reviewed May 8, 2019
View reviewed changes
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
@patrickf949 patrickf949 force-pushed the ft-design-home-page-165819922 branch from a9130ae to 9f71596 Compare May 8, 2019 15:41
houndci-bot
houndci-bot reviewed May 8, 2019
View reviewed changes
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
@patrickf949 patrickf949 force-pushed the ft-design-home-page-165819922 branch from 9f71596 to 2dbae81 Compare May 8, 2019 15:44
houndci-bot
houndci-bot reviewed May 8, 2019
View reviewed changes
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
@patrickf949 patrickf949 force-pushed the ft-design-home-page-165819922 branch from 2dbae81 to c3f5032 Compare May 8, 2019 16:05
@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-11 May 8, 2019 16:05 Inactive
houndci-bot
houndci-bot reviewed May 8, 2019
View reviewed changes
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
@patrickf949 patrickf949 force-pushed the ft-design-home-page-165819922 branch from c3f5032 to 3dadd92 Compare May 8, 2019 16:22
@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-11 May 8, 2019 16:22 Inactive
@patrickf949 patrickf949 force-pushed the ft-design-home-page-165819922 branch from 3dadd92 to 82218db Compare May 8, 2019 17:09
@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-11 May 8, 2019 17:10 Inactive
@patrickf949 patrickf949 force-pushed the ft-design-home-page-165819922 branch from 82218db to 4d9dc94 Compare May 8, 2019 18:51
houndci-bot
houndci-bot reviewed May 8, 2019
View reviewed changes
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-11 May 8, 2019 18:51 Inactive
@patrickf949 patrickf949 force-pushed the ft-design-home-page-165819922 branch from 4d9dc94 to 8151aa4 Compare May 8, 2019 19:16
houndci-bot
houndci-bot reviewed May 8, 2019
View reviewed changes
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-11 May 8, 2019 19:17 Inactive
@patrickf949 patrickf949 force-pushed the ft-design-home-page-165819922 branch from 8151aa4 to 2549fc0 Compare May 8, 2019 21:20
houndci-bot
houndci-bot reviewed May 8, 2019
View reviewed changes
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
src/styles/app.scss Outdated Show resolved Hide resolved
@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-11 May 8, 2019 21:20 Inactive
@patrickf949 patrickf949 force-pushed the ft-design-home-page-165819922 branch from 2549fc0 to dd80430 Compare May 8, 2019 21:22
houndci-bot
houndci-bot reviewed May 9, 2019
View reviewed changes
src/containers/app.js Show resolved Hide resolved
src/components/routes.js Show resolved Hide resolved
houndci-bot
houndci-bot reviewed May 9, 2019
View reviewed changes
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/index.js Show resolved Hide resolved
src/containers/app.js Show resolved Hide resolved
src/components/routes.js Show resolved Hide resolved
houndci-bot
houndci-bot reviewed May 9, 2019
View reviewed changes
src/tests/mock_data/moxios_mock.js Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/index.js Show resolved Hide resolved
anyatibrian
anyatibrian approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@anyatibrian anyatibrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @patrickf949 greate work

@patrickf949 patrickf949 force-pushed the ft-design-home-page-165819922 branch from 3b02f88 to 69c6fff Compare May 9, 2019 15:58
@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-11 May 9, 2019 15:58 Inactive
@patrickf949 patrickf949 force-pushed the ft-design-home-page-165819922 branch from 69c6fff to 015265d Compare May 9, 2019 18:00
@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-11 May 9, 2019 18:01 Inactive
houndci-bot
houndci-bot reviewed May 9, 2019
View reviewed changes
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
e-ian
e-ian approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@e-ian e-ian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @patrickf949. LGTM

MuhanguziDavid
MuhanguziDavid suggested changes May 9, 2019
View reviewed changes
Copy link
Contributor

@MuhanguziDavid MuhanguziDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @patrickf949 , please

  • update your commit footer to Finishes instead of Maintains
  • Work on coverage, it should be higher than that

@patrickf949 patrickf949 force-pushed the ft-design-home-page-165819922 branch 2 times, most recently from 59910b1 to 5b65e91 Compare May 10, 2019 04:34
@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-11 May 10, 2019 04:35 Inactive
@patrickf949 patrickf949 force-pushed the ft-design-home-page-165819922 branch from 5b65e91 to 7439b2a Compare May 10, 2019 05:19
houndci-bot
houndci-bot reviewed May 10, 2019
View reviewed changes
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-11 May 10, 2019 05:19 Inactive
@patrickf949
Copy link
Contributor Author

Nice work @patrickf949 , please

  • update your commit footer to Finishes instead of Maintains
  • Work on coverage, it should be higher than that

Thanks @MuhanguziDavid , all done

@patrickf949 patrickf949 force-pushed the ft-design-home-page-165819922 branch from 7439b2a to 97ccabd Compare May 10, 2019 05:28
@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-11 May 10, 2019 05:29 Inactive
@patrickf949
ft(landing-page): create landing page
fd01629 
 - add header for all pages
 - fetch articles from the backend using axios
 - style landing page

[Finishes #165819922]
@patrickf949 patrickf949 force-pushed the ft-design-home-page-165819922 branch from 97ccabd to fd01629 Compare May 10, 2019 08:03
MuhanguziDavid
MuhanguziDavid approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@MuhanguziDavid MuhanguziDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MuhanguziDavid MuhanguziDavid merged commit 022bbf1 into develop May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@anyatibrian anyatibrian anyatibrian approved these changes

@e-ian e-ian e-ian approved these changes

@MuhanguziDavid MuhanguziDavid MuhanguziDavid approved these changes

@Genza999 Genza999 Awaiting requested review from Genza999

Assignees
No one assigned
Labels
finished TTL review ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@patrickf949 @houndci-bot @anyatibrian @e-ian @MuhanguziDavid