Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#162693956 Fix Heroku App #28

Merged
merged 1 commit into from
Dec 20, 2018
Merged

#162693956 Fix Heroku App #28

merged 1 commit into from
Dec 20, 2018

Conversation

dnuwa
Copy link
Contributor

@dnuwa dnuwa commented Dec 19, 2018

What does this PR do?

  • Fixes Heroku deployment errors.

Description of Task to be completed?

  • add API URLs to front-end components.

How should this be manually tested?

try it out on the this link

What are the relevant pivotal tracker stories?

#162693956

@brucemakallan brucemakallan temporarily deployed to ah-frontend-thanos-stagi-pr-28 December 19, 2018 17:52 Inactive
@brucemakallan brucemakallan requested a deployment to ah-frontend-thanos-stagi-pr-28 December 19, 2018 17:53 Abandoned
@brucemakallan brucemakallan requested a deployment to ah-frontend-thanos-stagi-pr-28 December 19, 2018 17:53 Abandoned
@brucemakallan brucemakallan requested a deployment to ah-frontend-thanos-stagi-pr-28 December 19, 2018 17:54 Abandoned
@brucemakallan brucemakallan requested a deployment to ah-frontend-thanos-stagi-pr-28 December 19, 2018 17:56 Abandoned
@brucemakallan brucemakallan requested a deployment to ah-frontend-thanos-stagi-pr-28 December 19, 2018 17:58 Abandoned
@brucemakallan brucemakallan requested a deployment to ah-frontend-thanos-stagi-pr-28 December 19, 2018 18:04 Abandoned
@dnuwa dnuwa temporarily deployed to ah-frontend-thanos-stagi-pr-28 December 19, 2018 18:08 Inactive
@dnuwa dnuwa temporarily deployed to ah-frontend-thanos-stagi-pr-28 December 19, 2018 18:27 Inactive
brucemakallan
brucemakallan previously approved these changes Dec 19, 2018
- adds api URLs to react components and tests

[#162693956]
@codeclimate
Copy link

codeclimate bot commented Dec 19, 2018

Code Climate has analyzed commit 5e343f8 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@RachaelNantale RachaelNantale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Daniel, for fixing Heroku. I have checked it out and it works fine.

@tibetegya tibetegya merged commit cf70d30 into develop Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants