#163459553 Fix post rating #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 24, 2019
authors/apps/ratings/views.py
Outdated
|
|
||
| serializer.is_valid(raise_exception=True) | ||
| serializer.save() | ||
|
|
||
| rating = Rating.objects.get(rater_id=request.user.id) | ||
| rating = Rating.objects.get(rater_id=request.user.id, article_id=article.id) |
There was a problem hiding this comment.
line too long (84 > 79 characters)
authors/apps/ratings/views.py
Outdated
| # perform an update if exists | ||
| serializer = BasicRatingSerializer( | ||
| current_rating, data=request.data, partial=True) | ||
|
|
||
| except Rating.DoesNotExist: | ||
| # create a new rating if does not exists | ||
| serializer = BasicRatingSerializer(data=rating_data) | ||
|
|
authors/apps/ratings/views.py
Outdated
| @@ -41,19 +40,20 @@ def post(self, request, slug): | |||
|
|
|||
| # check if rating exists for the article | |||
| try: | |||
| current_rating = Rating.objects.get(rater_id=request.user.id) | |||
| current_rating = Rating.objects.get(rater_id=request.user.id, article_id=article.id) | |||
There was a problem hiding this comment.
line too long (96 > 79 characters)
[Finishes #163459553]
gwako94
force-pushed
the
fix-post-article-rating-163459553
branch
from
4f9df8a
to
7ba9595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix user can rate multiple articles
Description of Task to be completed?
Have user rating multiple articles
How should this be manually tested?
Test as described in this PR
Any background context you want to provide?
What are the relevant pivotal tracker stories?
#163459553
Screenshots (if appropriate)
Questions:
Checklist: