-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#164046248] Users can reset their password #24
Conversation
2e2ee9d
to
016db71
Compare
@RachelleMaina, please fix the failing build. |
016db71
to
7663401
Compare
7663401
to
a32c1f4
Compare
a32c1f4
to
94b4914
Compare
94b4914
to
650a54b
Compare
650a54b
to
40c13c6
Compare
40c13c6
to
f8bba36
Compare
f8bba36
to
aae0040
Compare
aae0040
to
a70cd50
Compare
a70cd50
to
2978062
Compare
@abulojoshua1 The build is failing because there is a test that is failing on travis. The test is running locally, so am at a loss. I am continually trying to find a solution for this. |
2978062
to
bd5b498
Compare
bd5b498
to
5756ff5
Compare
5756ff5
to
9070363
Compare
9070363
to
9e0301a
Compare
@abulojoshua1 The build is now passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Could you please list any non-breaking changes you included in this PR? |
Will do |
9e0301a
to
1e7dea9
Compare
1e7dea9
to
f49982a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works great
f49982a
to
472ed17
Compare
472ed17
to
1b79c9e
Compare
- add user supply their email address functionality - add user can receive a password reset link on their email - add user can change their password - add user cannot use a password reset token twice - add tests - update README.md [Finishes #164046248]
1b79c9e
to
b2f4348
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adds password reset functionality which is valuable in instances where users forget their login credentials.
Type of change
How Has This Been Tested
Checklist
How can this be manually tested?
The two endpoints require a registered user. A user supplies their registered email address and a callback URL which is the domain of the application. A link containing the token is sent to the supplied email address. On clicking the link, a user is redirected to the page contained in the call back URL where they will reset their password. Here they supply a password and a confirm password. This is then updated.
POST /api/users/password-reset/
Example request body:
PUT /api/users/password-reset/
Example request body:
PT
#164046248