Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ft(article-bookmark): bookmark an article #18

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

Emile-Nsengimana
Copy link
Contributor

@Emile-Nsengimana Emile-Nsengimana commented Sep 6, 2019

What does this PR do?

This PR will create UI component to:

  • Bookmark an article

Description of Task to be completed?

  • Bookmark articles for reading later

How should this be manually tested?

First git clone https://github.com/andela/ah-lobos-frontend.git

Then :
navigate into the project directory

cd ah-lobos-frontend

install all dependencies

npm install

run test for end-to-end

npm run cypress

run test for unit test

npm run test

start application

npm start

  • Your default browser will open, click read on any article then bookmark the article on the right side of your screen.

Any background context you want to provide?

  • N/A

What are the relevant pivotal tracker stories?

#166789848

Screenshots (if appropriate)

ezgif com-video-to-gif

Questions:

  • N/A

@Emile-Nsengimana Emile-Nsengimana force-pushed the ft-article-bookmark-166789848 branch 18 times, most recently from 04d4098 to cbc125b Compare September 9, 2019 08:51
@Emile-Nsengimana Emile-Nsengimana force-pushed the ft-article-bookmark-166789848 branch 9 times, most recently from 4f211e7 to aeef50f Compare September 10, 2019 13:22
@Emile-Nsengimana Emile-Nsengimana force-pushed the ft-article-bookmark-166789848 branch 12 times, most recently from 6631b3e to 3146284 Compare September 10, 2019 21:31
Copy link
Contributor

@manzif manzif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you did a great job. But there are commented codes in the following files.

  • src/views/comment.js
  • src/views/BookmarkedArticle.js
  • src/redux/actions/articlesAction.js.
    Keep up the good work.

@Emile-Nsengimana Emile-Nsengimana added TTL REVIEW This doesn't seem right and removed PEER REVIEW labels Sep 11, 2019
  - allow a use to bookmark an article
  - allow a user to read bookmarked article
  - allow a user to unbookmark article

[Finishes #166789848]
@kamyaD kamyaD merged commit 56ceb31 into develop Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TTL REVIEW This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants