#166841007 User signin endpoint #27

chokonaira · 2019-07-06T09:54:51Z

What does this PR do?

-An endpoint for existing users to sign in on Authors Heaven

Description of Task to be completed?

-Integrated JWT for authentication - user sign-in route

How should this be manually tested?

-git clone https://github.com/andela/ah-nyati-backend.git
-navigate to http://localhost:3000/api/v1/auth/login

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#166841007

Screenshots (if appropriate)

Questions:
-N/A

hound · 2019-07-06T09:54:56Z

src/helpers/mail/Mailer.js

@@ -0,0 +1,35 @@
+import nodemailer from 'nodemailer';


Definition for rule 'jsx-a11y/anchor-is-valid' was not found jsx-a11y/anchor-is-valid

hound · 2019-07-06T09:54:56Z

src/helpers/mail/MailTemplate.js

@@ -0,0 +1,70 @@
+/**


Definition for rule 'jsx-a11y/anchor-is-valid' was not found jsx-a11y/anchor-is-valid

hound · 2019-07-06T09:54:56Z

src/helpers/helpers.js

@@ -0,0 +1,57 @@
+import jwt from 'jsonwebtoken';


Definition for rule 'jsx-a11y/anchor-is-valid' was not found jsx-a11y/anchor-is-valid

hound · 2019-07-06T09:54:56Z

src/controllers/Auth.js

+import Template from '../helpers/mail/MailTemplate';
+import Mailer from '../helpers/mail/Mailer';
+
+const { generateToken, comparePassword } = Auth;


'comparePassword' is assigned a value but never used no-unused-vars

hound · 2019-07-06T09:54:57Z

src/controllers/Auth.js

@@ -1,44 +1,101 @@
-import auth from '../middleware/Auth';
+import passwordHash from 'password-hash';


Definition for rule 'jsx-a11y/anchor-is-valid' was not found jsx-a11y/anchor-is-valid

hound · 2019-07-10T16:30:53Z

src/db/migrations/20190709125502-create-tag.js

+      defaultValue: Sequelize.literal('CURRENT_TIMESTAMP')
+    }
+  }),
+  down: (queryInterface, Sequelize) => queryInterface.dropTable('Tags')


'Sequelize' is defined but never used no-unused-vars

hound · 2019-07-10T16:30:53Z

test/user.test.js

      .end((err, res) => {
-        token = res.body.data;
+        token  = res.body.token;


Multiple spaces found before '=' no-multi-spaces
Use object destructuring prefer-destructuring

hound · 2019-07-10T16:30:54Z

test/auth.test.js

+      chai.request(app).post('/api/v1/auth/login')
+        .send(existingUser)
+        .end((err, res) => {
+          token = res.body.token;


Use object destructuring prefer-destructuring

hound · 2019-07-10T16:30:54Z

test/auth.test.js

+describe('Auth', () => {
+  before(() => {
+    const email = ['main.jane@gmail.com', 'main.jane3@gmail.com'];
+    email.map((i) => {


Expected to return a value in arrow function array-callback-return

hound · 2019-07-10T16:30:54Z

src/db/migrations/20190709090055-create-like.js

+      type: Sequelize.DATE
+    }
+  }),
+  down: (queryInterface, Sequelize) => queryInterface.dropTable('Likes'),


'Sequelize' is defined but never used no-unused-vars

hound · 2019-07-10T23:16:36Z

src/controllers/Auth.js

      return res.status(201).json({
        status: 201,
        message: 'A link has been sent to your mailbox for verification',
        token
      });
    } catch (err) {
+      console.log(err);


Unexpected console statement no-console

fob413 · 2019-07-11T11:35:40Z

src/controllers/Auth.js

 import { Blacklist, User } from '../db/models';
 import template from '../helpers/mail/mailTemplate/signupEmailTemplate';
 import sendEmail from '../helpers/mail/mailer';

 const { generateToken, verifyToken } = Auth;
-
+dotenv.config();
+const isTest = process.env.NODE_ENV === 'test';


This should come from the config.js file

fob413 · 2019-07-11T11:40:17Z

src/helpers/helpers.js

@@ -25,7 +25,7 @@ export class Auth {
  /**
   *
   *@description Verifies token
-   * @param { string } token
+   * @param {*} token


please revert this change with what is on staging

fob413 · 2019-07-11T11:40:21Z

src/helpers/mail/mailer.js

-  )
-);
+dotenv.config();
+


please revert this change with what is on staging

hound · 2019-07-11T11:57:46Z

src/db/migrations/30181008085214-create-rating.js

+      type: Sequelize.DATE
+    }
+  }),
+  down: (queryInterface, Sequelize) => queryInterface.dropTable('Ratings'),


'Sequelize' is defined but never used no-unused-vars

Integrate user signin route [Delivers #166841007]

codeBlock-1984

Nice job @chokonaira.

hound bot reviewed Jul 6, 2019

View reviewed changes

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-27 July 6, 2019 09:55 Inactive

chokonaira force-pushed the ft-user-signin-route-166841007 branch from 0e07545 to dc29130 Compare July 6, 2019 19:29

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-27 July 6, 2019 19:29 Inactive

chokonaira force-pushed the ft-user-signin-route-166841007 branch from dc29130 to 8765f46 Compare July 6, 2019 19:37

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-27 July 6, 2019 19:37 Inactive

Alpha1202 added the rebase required label Jul 9, 2019

chokonaira force-pushed the ft-user-signin-route-166841007 branch from 8765f46 to 4972b63 Compare July 10, 2019 16:30

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-27 July 10, 2019 16:30 Inactive

hound bot reviewed Jul 10, 2019

View reviewed changes

chokonaira force-pushed the ft-user-signin-route-166841007 branch from 4972b63 to 7e82f2b Compare July 10, 2019 23:16

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-27 July 10, 2019 23:16 Inactive

hound bot reviewed Jul 10, 2019

View reviewed changes

chokonaira force-pushed the ft-user-signin-route-166841007 branch from 7e82f2b to beedb87 Compare July 10, 2019 23:25

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-27 July 10, 2019 23:25 Inactive

chokonaira force-pushed the ft-user-signin-route-166841007 branch from beedb87 to e172c78 Compare July 10, 2019 23:29

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-27 July 10, 2019 23:30 Inactive

fob413 reviewed Jul 11, 2019

View reviewed changes

src/helpers/mail/mailer.js

)

);

dotenv.config();

Copy link

Contributor

fob413 Jul 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this change with what is on staging

chokonaira force-pushed the ft-user-signin-route-166841007 branch from e172c78 to e1a919a Compare July 11, 2019 11:57

hound bot reviewed Jul 11, 2019

View reviewed changes

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-27 July 11, 2019 11:57 Inactive

chokonaira force-pushed the ft-user-signin-route-166841007 branch from e1a919a to 4c732bd Compare July 11, 2019 12:30

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-27 July 11, 2019 12:31 Inactive

feat(Auth):User signin endpoint

2c7faab

Integrate user signin route [Delivers #166841007]

chokonaira force-pushed the ft-user-signin-route-166841007 branch from 4c732bd to 2c7faab Compare July 11, 2019 13:36

czarjulius deployed to ah-nyati-backend-staging-pr-27 July 11, 2019 13:36 View deployment

phembarl approved these changes Jul 11, 2019

View reviewed changes

czarjulius approved these changes Jul 11, 2019

View reviewed changes

codeBlock-1984 approved these changes Jul 11, 2019

View reviewed changes

fob413 merged commit f6d1f2b into staging Jul 11, 2019

fob413 deleted the ft-user-signin-route-166841007 branch July 11, 2019 13:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#166841007 User signin endpoint #27

#166841007 User signin endpoint #27

chokonaira commented Jul 6, 2019

hound bot Jul 6, 2019

hound bot Jul 6, 2019

hound bot Jul 6, 2019

hound bot Jul 6, 2019

hound bot Jul 6, 2019

hound bot Jul 10, 2019

hound bot Jul 10, 2019

hound bot Jul 10, 2019

hound bot Jul 10, 2019

hound bot Jul 10, 2019

hound bot Jul 10, 2019

fob413 Jul 11, 2019

fob413 Jul 11, 2019

fob413 Jul 11, 2019

hound bot Jul 11, 2019

codeBlock-1984 left a comment

		@@ -1,44 +1,101 @@
		import auth from '../middleware/Auth';
		import passwordHash from 'password-hash';

#166841007 User signin endpoint #27

#166841007 User signin endpoint #27

Conversation

chokonaira commented Jul 6, 2019

hound bot Jul 6, 2019

Choose a reason for hiding this comment

hound bot Jul 6, 2019

Choose a reason for hiding this comment

hound bot Jul 6, 2019

Choose a reason for hiding this comment

hound bot Jul 6, 2019

Choose a reason for hiding this comment

hound bot Jul 6, 2019

Choose a reason for hiding this comment

hound bot Jul 10, 2019

Choose a reason for hiding this comment

hound bot Jul 10, 2019

Choose a reason for hiding this comment

hound bot Jul 10, 2019

Choose a reason for hiding this comment

hound bot Jul 10, 2019

Choose a reason for hiding this comment

hound bot Jul 10, 2019

Choose a reason for hiding this comment

hound bot Jul 10, 2019

Choose a reason for hiding this comment

fob413 Jul 11, 2019

Choose a reason for hiding this comment

fob413 Jul 11, 2019

Choose a reason for hiding this comment

fob413 Jul 11, 2019

Choose a reason for hiding this comment

hound bot Jul 11, 2019

Choose a reason for hiding this comment

codeBlock-1984 left a comment

Choose a reason for hiding this comment