#166841020 Users should be able to like articles #36

phembarl · 2019-07-09T19:40:57Z

What does this PR do?

Enables a user to like and unlike articles

Description of Task to be completed?

Create likes table
Create API endpoint that enables a user to make a POST request to like an article

How should this be manually tested?

After running your server, make an API POST request to the following address: localhost:3000/api/v1/articles/<slug>/like

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

166841020
https://www.pivotaltracker.com/story/show/166841020

Screenshots (if appropriate)

N/A

Questions:

N/A

hound · 2019-07-09T19:41:06Z

src/routes/userRoute.js

+router.put('/profiles/:id',
+  verify, upload.single('avatar'),
+  profileChecker,
+  UserController.updateProfile);


Expected a newline before ')' function-paren-newline

hound · 2019-07-09T19:41:07Z

src/routes/userRoute.js

+  verify,
+  UserController.getUserProfile);
+
+router.put('/profiles/:id',


Expected a newline after '(' function-paren-newline

hound · 2019-07-09T19:41:07Z

src/routes/userRoute.js

+
+router.get('/profiles/:userName',
+  verify,
+  UserController.getUserProfile);


Expected a newline before ')' function-paren-newline

hound · 2019-07-09T19:41:07Z

src/routes/userRoute.js

+
+const router = express.Router();
+
+router.get('/profiles/:userName',


Expected a newline after '(' function-paren-newline

hound · 2019-07-09T19:41:07Z

src/routes/likeRoute.js

+
+router.post('/articles/:slug/like',
+  verify,
+  LikeController.likeArticle);


Expected a newline before ')' function-paren-newline

hound · 2019-07-09T19:41:07Z

src/routes/likeRoute.js

+
+const router = express.Router();
+
+router.post('/articles/:slug/like',


Expected a newline after '(' function-paren-newline

hound · 2019-07-09T19:41:07Z

src/db/models/blacklist.js

@@ -8,7 +8,7 @@ module.exports = (sequelize, DataTypes) => {
      defaultValue: true
    },
  }, {});
-  Blacklist.associate = function(models) {
+  Blacklist.associate = (models) => {


'models' is defined but never used no-unused-vars

hound · 2019-07-09T19:41:07Z

src/db/migrations/20190709090055-create-like.js

+      type: Sequelize.DATE
+    }
+  }),
+  down: (queryInterface, Sequelize) => queryInterface.dropTable('Likes'),


'Sequelize' is defined but never used no-unused-vars

hound · 2019-07-09T19:41:08Z

src/db/migrations/20190701212849-create-blacklist.js

-  down: (queryInterface, Sequelize) => {
-    return queryInterface.dropTable('Blacklists');
-  }
+  down: (queryInterface, Sequelize) => queryInterface.dropTable('Blacklists'),


'Sequelize' is defined but never used no-unused-vars

hound · 2019-07-09T19:57:20Z

src/db/migrations/20190709125502-create-tag.js

+      defaultValue: Sequelize.literal('CURRENT_TIMESTAMP')
+    }
+  }),
+  down: (queryInterface, Sequelize) => queryInterface.dropTable('Tags')


'Sequelize' is defined but never used no-unused-vars

codeBlock-1984

I can see that you have squashed your commits into two. Nice job @phembarl

hound · 2019-07-11T18:23:41Z

test/like.test.js

+    chai.request(app).post('/api/v1/auth/login')
+      .send(user)
+      .end((err, res) => {
+        token = res.body.token;


Use object destructuring prefer-destructuring

hound · 2019-07-11T18:23:41Z

test/like.test.js

+    chai.request(app).post('/api/v1/auth/login')
+      .send(user)
+      .end((err, res) => {
+        token = res.body.token;


Use object destructuring prefer-destructuring

hound · 2019-07-11T18:23:41Z

test/auth.test.js

@@ -40,6 +40,7 @@ describe('Auth', () => {
      chai.request(app).post('/api/v1/auth/signup')
        .send(defaultUser)
        .end((err, res) => {
+          console.log(res.body);


Unexpected console statement no-console

hound · 2019-07-11T20:09:01Z

test/like.test.js

+    chai.request(app).post('/api/v1/auth/login')
+      .send(user)
+      .end((err, res) => {
+        token = res.body.token;


Use object destructuring prefer-destructuring

fob413 · 2019-07-12T01:21:18Z

test/like.test.js

+      });
+  });
+
+  it('should not return the right error message', (done) => {


What do you mean by it should not return the right error message

fob413 · 2019-07-12T01:22:52Z

src/controllers/likeController.js

+    const userId = req.user;
+
+    try {
+      const article = await Article.findOne({


Can you please move the aspect of finding if an article exists or not to a middleware. This middleware should be reusable. Also, confirm that it doesn't already exist in our codebase

hound · 2019-07-15T10:18:44Z

test/like.test.js

+        chai.request(app).post('/api/v1/articles/article/like')
+          .set('token', testToken)
+          .end((err, res) => {
+            console.log(res.body);


Unexpected console statement no-console

hound · 2019-07-15T10:18:44Z

test/like.test.js

+        chai.request(app).post('/api/v1/articles/article/like')
+          .set('token', testToken)
+          .end((err, res) => {
+            console.log(res.body);


Unexpected console statement no-console

hound · 2019-07-15T11:02:41Z

src/controllers/likeController.js

+ * @memberof LikeController
+ */
+  static async likeArticle(req, res) {
+    const { slug } = req.params;


'slug' is assigned a value but never used no-unused-vars

hound · 2019-07-15T11:02:41Z

src/controllers/likeController.js

@@ -0,0 +1,56 @@
+import { Article, Like } from '../db/models';


'Article' is defined but never used no-unused-vars

…er to like an article - [Finishes #166841020] feature(likes): user should be able to like an article - enables a user to like an article - [Finishes #166841020]

hound bot reviewed Jul 9, 2019

View reviewed changes

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-36 July 9, 2019 19:41 Inactive

phembarl force-pushed the ft-like-articles-166841020 branch from 9af244b to b80c479 Compare July 9, 2019 19:57

hound bot reviewed Jul 9, 2019

View reviewed changes

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-36 July 9, 2019 19:57 Inactive

chokonaira approved these changes Jul 10, 2019

View reviewed changes

phembarl force-pushed the ft-like-articles-166841020 branch from b80c479 to bf4e151 Compare July 10, 2019 11:46

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-36 July 10, 2019 11:47 Inactive

codeBlock-1984 approved these changes Jul 10, 2019

View reviewed changes

phembarl force-pushed the ft-like-articles-166841020 branch from bf4e151 to 7516c99 Compare July 11, 2019 18:23

hound bot reviewed Jul 11, 2019

View reviewed changes

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-36 July 11, 2019 18:23 Inactive

phembarl force-pushed the ft-like-articles-166841020 branch from 7516c99 to 5fc120b Compare July 11, 2019 20:08

hound bot reviewed Jul 11, 2019

View reviewed changes

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-36 July 11, 2019 20:09 Inactive

czarjulius approved these changes Jul 11, 2019

View reviewed changes

fob413 reviewed Jul 12, 2019

View reviewed changes

phembarl force-pushed the ft-like-articles-166841020 branch from 5fc120b to 23cf8c4 Compare July 12, 2019 08:21

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-36 July 12, 2019 08:21 Inactive

phembarl force-pushed the ft-like-articles-166841020 branch from 23cf8c4 to 00226af Compare July 15, 2019 09:54

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-36 July 15, 2019 09:54 Inactive

phembarl force-pushed the ft-like-articles-166841020 branch from 00226af to 2ab5fc7 Compare July 15, 2019 10:18

hound bot reviewed Jul 15, 2019

View reviewed changes

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-36 July 15, 2019 10:18 Inactive

phembarl force-pushed the ft-like-articles-166841020 branch from 2ab5fc7 to 5871ed9 Compare July 15, 2019 10:29

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-36 July 15, 2019 10:29 Inactive

phembarl force-pushed the ft-like-articles-166841020 branch from 5871ed9 to a71b4ba Compare July 15, 2019 11:02

hound bot reviewed Jul 15, 2019

View reviewed changes

czarjulius temporarily deployed to ah-nyati-backend-staging-pr-36 July 15, 2019 11:02 Inactive

feature(likes): user should be able to like an article - enables a us…

1d96613

…er to like an article - [Finishes #166841020] feature(likes): user should be able to like an article - enables a user to like an article - [Finishes #166841020]

phembarl force-pushed the ft-like-articles-166841020 branch from a71b4ba to 1d96613 Compare July 15, 2019 11:09

czarjulius deployed to ah-nyati-backend-staging-pr-36 July 15, 2019 11:09 View deployment

czarjulius merged commit 8046491 into staging Jul 15, 2019

czarjulius deleted the ft-like-articles-166841020 branch July 15, 2019 15:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#166841020 Users should be able to like articles #36

#166841020 Users should be able to like articles #36

phembarl commented Jul 9, 2019 •

edited

Loading

hound bot Jul 9, 2019

hound bot Jul 9, 2019

hound bot Jul 9, 2019

hound bot Jul 9, 2019

hound bot Jul 9, 2019

hound bot Jul 9, 2019

hound bot Jul 9, 2019

hound bot Jul 9, 2019

hound bot Jul 9, 2019

hound bot Jul 9, 2019

codeBlock-1984 left a comment

hound bot Jul 11, 2019

hound bot Jul 11, 2019

hound bot Jul 11, 2019

hound bot Jul 11, 2019

fob413 Jul 12, 2019

fob413 Jul 12, 2019

hound bot Jul 15, 2019

hound bot Jul 15, 2019

hound bot Jul 15, 2019

hound bot Jul 15, 2019


		const router = express.Router();

		router.get('/profiles/:userName',


		const router = express.Router();

		router.post('/articles/:slug/like',

		@@ -0,0 +1,56 @@
		import { Article, Like } from '../db/models';

#166841020 Users should be able to like articles #36

#166841020 Users should be able to like articles #36

Conversation

phembarl commented Jul 9, 2019 • edited Loading

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

Any background context you want to provide?

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

Questions:

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

codeBlock-1984 left a comment

Choose a reason for hiding this comment

hound bot Jul 11, 2019

Choose a reason for hiding this comment

hound bot Jul 11, 2019

Choose a reason for hiding this comment

hound bot Jul 11, 2019

Choose a reason for hiding this comment

hound bot Jul 11, 2019

Choose a reason for hiding this comment

fob413 Jul 12, 2019

Choose a reason for hiding this comment

fob413 Jul 12, 2019

Choose a reason for hiding this comment

hound bot Jul 15, 2019

Choose a reason for hiding this comment

hound bot Jul 15, 2019

Choose a reason for hiding this comment

hound bot Jul 15, 2019

Choose a reason for hiding this comment

hound bot Jul 15, 2019

Choose a reason for hiding this comment

phembarl commented Jul 9, 2019 •

edited

Loading