#167982241 User can update their articles #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
test/article.test.js
Outdated
| @@ -52,6 +53,8 @@ describe('Articles', () => { | |||
| .field(testArticle) | |||
| .attach('images', path.join(__dirname, 'img/test.jpg'), 'test.png') | |||
| .end((err, res) => { | |||
| slug = res.body.data[0].slug; | |||
| userId = res.body.data[0].userId; | |||
There was a problem hiding this comment.
Use object destructuring prefer-destructuring
test/article.test.js
Outdated
| @@ -52,6 +53,8 @@ describe('Articles', () => { | |||
| .field(testArticle) | |||
| .attach('images', path.join(__dirname, 'img/test.jpg'), 'test.png') | |||
| .end((err, res) => { | |||
| slug = res.body.data[0].slug; | |||
There was a problem hiding this comment.
Use object destructuring prefer-destructuring
test/article.test.js
Outdated
| @@ -10,7 +10,8 @@ dotenv.config(); | |||
|
|
|||
| chai.use(chaiHttp); | |||
| chai.should(); | |||
|
|
|||
| let slug; | |||
| let userId; | |||
There was a problem hiding this comment.
'userId' is assigned a value but never used no-unused-vars
chokonaira
approved these changes
Aug 20, 2019
Cavdy
approved these changes
Aug 20, 2019
Alpha1202
approved these changes
Aug 20, 2019
phembarl
approved these changes
Aug 20, 2019
czarjulius
force-pushed
the
ft-user-update-article-167982241
branch
from
db2270d
to
0aec55b
Compare
…ticle method-validate article fields-create the update article routes-write unit test for update article[Delivers #167982241]
czarjulius
force-pushed
the
ft-user-update-article-167982241
branch
from
0aec55b
to
ceeeb7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
User can update the articles they authored.
Description of Task to be completed?
How should this be manually tested?
api/v1/articles/:slugwith aPATCHmethod on postman and provide the changes he/she wants to make on the article.Any background context you want to provide?
What are the relevant pivotal tracker stories?
Screenshots (if appropriate)
Questions: