Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#165305279 Get all bookmarked articles. #30

Merged
merged 1 commit into from
May 9, 2019

Conversation

katherine95
Copy link
Contributor

What does this PR do?

Fix the GET request for bookmarked articles

Description of Task to be completed?

  • Fix the return statement to be outside the for loop.

How should this be manually tested?

  1. Clone this repo.
    $ git clone https://github.com/andela/ah-the-jedi-backend.git
  2. Fetch all origin to get all branches
    $ git fetch origin
  3. Checkout to ft-user-bookmark-article-165305279 branch.
    $ git checkout ft-user-bookmark-article-165305279
  4. Activate virtualenv
    $ virtualenv -p python .venv
    $ source .venv/bin/activate
  5. Install requirements
    $ pip install -r requirements.txt
  6. Start server
    $ python manage.py runserver
  7. Test the endpoint on postman in the following steps:
  • Ensure the user is authenticated.
  • Get the articles you bookmarked - GET /api/articles/<slug>/bookmark/

What are the relevant pivotal tracker stories?

#165305279

Screenshot

Get all bookmarked articles
Screenshot 2019-05-08 at 16 56 52

#165305279 user can bookmark or unbookmark an article.
@katherine95 katherine95 requested a review from rnjane May 9, 2019 15:58
@rnjane rnjane merged commit 6ab269f into develop May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants