#164489929 create user profile #29

Paccy10 · 2019-04-09T13:42:19Z

What does this PR do?

This PR adds the functionality of creating a user profile

Description of Task to be completed?

creates GET: /api/users/:id/profile endpoint for getting a user profile
creates PUT :/api/users/:id/profile endpoint for updating a user profile
creates tests for GET: /api/users/:id/profile endpoint
creates tests for PUT :/api/users/:id/profile endpoint

How should this be manually tested?

go to postman and type http://localhost:3000/api/users/:id/profile (replace :id with the id of the user you want to view his profile), then send and you will get the profile
If you want to change your profile, go to postman and type http://localhost:3000/api/users/:id/profile (replace :id with your id), then add in the body what you want to update like username, bio or image and send, your profile will be updated.

What are the relevant pivotal tracker stories?

#164489929

Screenshots (if appropriate)

Response

houndci-bot · 2019-04-09T14:38:51Z

controllers/user.js

+        };
+        const updatedUser = await User.update(
+          profile, { where: { id }, returning: true, plain: true }
+        );


Unexpected newline before ')' function-paren-newline

houndci-bot · 2019-04-09T14:38:51Z

controllers/user.js

+          bio: req.body.bio ? req.body.bio : foundUser.bio,
+          image: req.file ? req.file.url : foundUser.image
+        };
+        const updatedUser = await User.update(


Unexpected newline after '(' function-paren-newline

houndci-bot · 2019-04-09T14:54:21Z

controllers/user.js

+          image: req.file ? req.file.url : foundUser.image
+        };
+        const updatedUser = await User.update(profile,
+          { where: { id }, returning: true, plain: true });


Expected a newline before ')' function-paren-newline

houndci-bot · 2019-04-09T14:54:21Z

controllers/user.js

+          bio: req.body.bio ? req.body.bio : foundUser.bio,
+          image: req.file ? req.file.url : foundUser.image
+        };
+        const updatedUser = await User.update(profile,


Expected a newline after '(' function-paren-newline

houndci-bot · 2019-04-09T15:33:08Z

controllers/user.js

+          bio: req.body.bio ? req.body.bio : foundUser.bio,
+          image: req.file ? req.file.url : foundUser.image
+        },
+        { where: { id }, returning: true, plain: true });


Expected a newline before ')' function-paren-newline

houndci-bot · 2019-04-09T15:33:08Z

controllers/user.js

+      const id = parseInt(req.params.id, 10);
+      const foundUser = await User.findOne({ where: { id } });
+      if (foundUser) {
+        const updatedUser = await User.update({


Expected a newline after '(' function-paren-newline

blaisebakundukize · 2019-04-10T08:49:35Z

Good work @Paccy10, I appreciate the way you handled your tasks. But I realized that you are passing user_id in the endpoint for updating the user's profile. I think you don't need to add user_id in the URL because we already have it in the token. As long as we are using Passport, you can access that user_id from user's requests. So you do not need that middleware for checking user account because it compares both user_id from token and URL. For example: const userId = req.user.id;

houndci-bot · 2019-04-10T09:31:05Z

test/1-user.js

+  invalidToken,
+  validToken,
+  profile1,
+  profile2


'profile2' is defined but never used no-unused-vars

houndci-bot · 2019-04-11T12:12:32Z

test/2-user.js

+import app from '../index';
+import {
+  signup1,
+  signup3,


'signup3' is defined but never used no-unused-vars

ruganda · 2019-04-12T07:49:21Z

@Paccy10 , Please fix these merge conflicts

-getting user profile -editing user profile [Delivers #164489929]

Paccy10 added the WIP label Apr 9, 2019

Paccy10 force-pushed the ft-create-user-profile-164489929 branch from f3cff02 to 74da9d1 Compare April 9, 2019 14:38

houndci-bot reviewed Apr 9, 2019

View reviewed changes

Paccy10 force-pushed the ft-create-user-profile-164489929 branch from 74da9d1 to 20c78fd Compare April 9, 2019 14:54

houndci-bot reviewed Apr 9, 2019

View reviewed changes

Paccy10 force-pushed the ft-create-user-profile-164489929 branch 2 times, most recently from 1daae43 to 37c737a Compare April 9, 2019 15:32

houndci-bot reviewed Apr 9, 2019

View reviewed changes

Paccy10 force-pushed the ft-create-user-profile-164489929 branch from 37c737a to 8528837 Compare April 9, 2019 16:17

Paccy10 added Ready for review and removed WIP labels Apr 9, 2019

Paccy10 force-pushed the ft-create-user-profile-164489929 branch from 8528837 to 00483e2 Compare April 10, 2019 09:30

houndci-bot reviewed Apr 10, 2019

View reviewed changes

test/1-user.js Outdated

invalidToken,

validToken,

profile1,

profile2

Copy link

houndci-bot Apr 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'profile2' is defined but never used no-unused-vars

Paccy10 force-pushed the ft-create-user-profile-164489929 branch from 00483e2 to 00d78a1 Compare April 10, 2019 09:41

Paccy10 changed the title ~~Feature(profile): User profile~~ #164489929 create user profile Apr 10, 2019

blaisebakundukize approved these changes Apr 10, 2019

View reviewed changes

Paccy10 force-pushed the ft-create-user-profile-164489929 branch from 00d78a1 to a2de2d5 Compare April 10, 2019 13:59

Paccy10 added the Finished label Apr 10, 2019

Paccy10 force-pushed the ft-create-user-profile-164489929 branch 2 times, most recently from 3d6895c to 185920a Compare April 11, 2019 12:12

houndci-bot reviewed Apr 11, 2019

View reviewed changes

test/2-user.js

import app from '../index';

import {

signup1,

signup3,

Copy link

houndci-bot Apr 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'signup3' is defined but never used no-unused-vars

Paccy10 force-pushed the ft-create-user-profile-164489929 branch 2 times, most recently from ae76ff7 to 01e3de6 Compare April 11, 2019 12:50

itsgratien temporarily deployed to badass-ah-backend-stagin-pr-29 April 11, 2019 12:51 Inactive

Paccy10 force-pushed the ft-create-user-profile-164489929 branch from 01e3de6 to 46d257d Compare April 12, 2019 07:59

itsgratien temporarily deployed to badass-ah-backend-stagin-pr-29 April 12, 2019 07:59 Inactive

Paccy10 force-pushed the ft-create-user-profile-164489929 branch from 46d257d to 0eae920 Compare April 12, 2019 08:44

itsgratien temporarily deployed to badass-ah-backend-stagin-pr-29 April 12, 2019 08:44 Inactive

Feature(profile): User profile

264b46f

-getting user profile -editing user profile [Delivers #164489929]

Paccy10 force-pushed the ft-create-user-profile-164489929 branch from 0eae920 to 264b46f Compare April 12, 2019 09:24

itsgratien deployed to badass-ah-backend-stagin-pr-29 April 12, 2019 09:24 View deployment

ruganda merged commit d5106f0 into develop Apr 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#164489929 create user profile #29

#164489929 create user profile #29

Paccy10 commented Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

blaisebakundukize commented Apr 10, 2019 •

edited

Loading

houndci-bot Apr 10, 2019

houndci-bot Apr 11, 2019

ruganda commented Apr 12, 2019

#164489929 create user profile #29

#164489929 create user profile #29

Conversation

Paccy10 commented Apr 9, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

blaisebakundukize commented Apr 10, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ruganda commented Apr 12, 2019

blaisebakundukize commented Apr 10, 2019 •

edited

Loading