#164489920 added test environment #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaman-dedy
approved these changes
Mar 19, 2019
Paccy10
reviewed
Mar 19, 2019
|
That is true, I wrote it using ES5 because we do not have babel set up yet. |
|
I appreciate the way you configured mocha and test script, but I see that you have used es5. I think you'd have installed the needed packages to transpile es6 to es5, then use es6. The test script, I see that it run all file inside the test folder. I was wondering if we could specify the exact files. For example, I want the script to run files have |
houndci-bot
reviewed
Mar 20, 2019
|
Hello @cop1fab , I think that it can be better to have one commit per PR, thanks to set it |
|
@cop1fab, Good work. Please look into;
|
Thank you for the feedback, this is has been added to my priority list. |
cop1fab
force-pushed
the
ch-test-164489920
branch
from
3017235
to
993826b
Compare
houndci-bot
reviewed
Mar 21, 2019
cop1fab
changed the title
houndci-bot
reviewed
Mar 21, 2019
cop1fab
force-pushed
the
ch-test-164489920
branch
from
4ed1369
to
6660179
Compare
houndci-bot
reviewed
Mar 21, 2019
cop1fab
force-pushed
the
ch-test-164489920
branch
4 times, most recently
from
1c8e353
to
e69e255
Compare
houndci-bot
reviewed
Mar 22, 2019
cop1fab
force-pushed
the
ch-test-164489920
branch
from
e69e255
to
dae8a08
Compare
houndci-bot
reviewed
Mar 22, 2019
cop1fab
force-pushed
the
ch-test-164489920
branch
from
dae8a08
to
d0f66b0
Compare
houndci-bot
reviewed
Mar 22, 2019
|
|
||
| const server = http.createServer(app); | ||
| app.listen(port, () => { | ||
| console.log(`Server started successfully on ${port}`); |
There was a problem hiding this comment.
Unexpected console statement no-console
cop1fab
force-pushed
the
ch-test-164489920
branch
from
d0f66b0
to
a7e5478
Compare
itsgratien
approved these changes
Mar 22, 2019
|
Thank you Copain, for the PR, I appreciate the work you did and the effort you put in. But I see a lot of comments of HoundCI about the code style. Somewhere it comments that you missed semicolon and arrow-space. Just configure well eslint in your editor so that next time you'll take care of the code style. |
- testing environment added using mocha & chai [Delivers #164489920]
cop1fab
force-pushed
the
ch-test-164489920
branch
from
a7e5478
to
b94b5c1
Compare
blaisebakundukize
approved these changes
Mar 22, 2019
Jaman-dedy
approved these changes
Mar 22, 2019
ruganda
approved these changes
Mar 25, 2019
Paccy10
pushed a commit
that referenced
this pull request
Apr 1, 2019
# This is the 1st commit message: Update README.md # This is the commit message #2: updated README.md Added code climate badges. # This is the commit message #3: chore(Added test): Added test environment - testing environment added using mocha & chai [Delivers #164489920] # This is the commit message #4: Update package.json # This is the commit message #5: Add Heroku generated app.json # This is the commit message #6: Feature (token): setting token based authentication -config JWT token using package called json web token [Delivers #164489923] mend # This is the commit message #7: [feature#164489925] added user validation # This is the commit message #8: Feature (token): setting token based authentication -config JWT token using package called json web token [Delivers #164489923] mend # This is the commit message #9: Feature(login): Login via google -creating an application on google -configure google OAuth passport strategy [Delivers #164489928] # This is the commit message #10: Feature(login): Login via google -creating an application on google -configure google OAuth passport strategy [Delivers #164489928]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR sets unit testing; ensuring all implemented functionality is tested henceforth. This ensures the back end has all functionality working as intended.
Description of Task to be completed?
How should it be tested manually?
After cloning the repo, run
npm install to install all necessary dependencies then run npm run test
Pivotal Tracker story?
#164489920