Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#164489917 Eslint Setup #2

Merged
merged 1 commit into from
Mar 21, 2019
Merged

#164489917 Eslint Setup #2

merged 1 commit into from
Mar 21, 2019

Conversation

itsgratien
Copy link
Contributor

@itsgratien itsgratien commented Mar 19, 2019

What Does this PR do?

setup eslint

Description of Task to be completed?

setup eslint to follow airbnb

How should this be manually tested?

  • open your terminal
  • change directory to project folder
  • write ./node_modules/.bin/eslint filename you want to lint

What are the relevant pivotal tracker stories?

#164489917

@Paccy10 Paccy10 self-requested a review March 19, 2019 10:23
@ruganda ruganda added the WIP label Mar 20, 2019
@itsgratien itsgratien changed the title Ch eslint setup 164489917 #164489917 eslint setup Mar 20, 2019
@itsgratien itsgratien changed the title #164489917 eslint setup #164489917 Eslint setup Mar 20, 2019
@itsgratien itsgratien changed the title #164489917 Eslint setup #164489917 Setup Eslint Mar 20, 2019
@itsgratien itsgratien changed the title #164489917 Setup Eslint #164489917 Eslint Setup Mar 20, 2019
@itsgratien itsgratien force-pushed the ch-eslintSetup-164489917 branch from 95ac63d to a310f4f Compare March 21, 2019 08:36
- ensure eslint is setup

[Delivers #164489917]

[ch #164489917] eslint file modified
@itsgratien itsgratien force-pushed the ch-eslintSetup-164489917 branch from a310f4f to 8ee90ef Compare March 21, 2019 08:39
@ruganda ruganda merged commit 23b0f8d into develop Mar 21, 2019
@ruganda ruganda deleted the ch-eslintSetup-164489917 branch March 21, 2019 08:47
Paccy10 pushed a commit that referenced this pull request Apr 1, 2019
# This is the 1st commit message:

Update README.md
# This is the commit message #2:

updated README.md

Added code climate badges.
# This is the commit message #3:

chore(Added test): Added test environment

- testing environment added using mocha & chai

[Delivers #164489920]

# This is the commit message #4:

Update package.json
# This is the commit message #5:

Add Heroku generated app.json
# This is the commit message #6:

Feature (token): setting token based authentication

 -config JWT token using package called json web token

 [Delivers #164489923]

mend

# This is the commit message #7:

[feature#164489925] added user validation

# This is the commit message #8:

Feature (token): setting token based authentication

 -config JWT token using package called json web token

 [Delivers #164489923]

mend

# This is the commit message #9:

Feature(login): Login via google

-creating an application on google
-configure google OAuth passport strategy

[Delivers #164489928]

# This is the commit message #10:

Feature(login): Login via google

-creating an application on google
-configure google OAuth passport strategy

[Delivers #164489928]
cop1fab pushed a commit that referenced this pull request Apr 10, 2019
# This is the 1st commit message:

Feature(article): create articles and view created articles

- allow user to create article
- image automatically uploaded on cloud

[Delivers #164489930]

# This is the commit message #2:

feature(Password Reset): Allowing a user to reset the password.

- ensuring that the user can reset the password in case it was forgotten.

[Delivers #164489927]
cop1fab pushed a commit that referenced this pull request Apr 10, 2019
# This is the 1st commit message:

Feature(article): create articles and view created articles

- allow user to create article
- image automatically uploaded on cloud

[Delivers #164489930]

# This is the commit message #2:

feature(Password Reset): Allowing a user to reset the password.

- ensuring that the user can reset the password in case it was forgotten.

[Delivers #164489927]
cop1fab pushed a commit that referenced this pull request Apr 11, 2019
# This is the 1st commit message:

Feature(article): create articles and view created articles

- allow user to create article
- image automatically uploaded on cloud

[Delivers #164489930]

# This is the commit message #2:

feature(Password Reset): Allowing a user to reset the password.

- ensuring that the user can reset the password in case it was forgotten.

[Delivers #164489927]
ruganda pushed a commit that referenced this pull request Apr 11, 2019
# This is the 1st commit message:

Feature(article): create articles and view created articles

- allow user to create article
- image automatically uploaded on cloud

[Delivers #164489930]

# This is the commit message #2:

feature(Password Reset): Allowing a user to reset the password.

- ensuring that the user can reset the password in case it was forgotten.

[Delivers #164489927]
cop1fab pushed a commit that referenced this pull request Apr 15, 2019
feature(Likes & Dislikes): Allowing a user to like or dislike an article.

- ensuring that the user can like or dislike an article.

[Delivers #164489935]

changes

changes
cop1fab pushed a commit that referenced this pull request Apr 15, 2019
feature(Likes & Dislikes): Allowing a user to like or dislike an article.

- ensuring that the user can like or dislike an article.

[Delivers #164489935]

changes

changes
cop1fab pushed a commit that referenced this pull request Apr 15, 2019
feature(Likes & Dislikes): Allowing a user to like or dislike an article.

- ensuring that the user can like or dislike an article.

[Delivers #164489935]

changes

changes
cop1fab pushed a commit that referenced this pull request Apr 17, 2019
feature(Likes & Dislikes): Allowing a user to like or dislike an article.

- ensuring that the user can like or dislike an article.

[Delivers #164489935]

changes

changes
cop1fab pushed a commit that referenced this pull request Apr 17, 2019
feature(Likes & Dislikes): Allowing a user to like or dislike an article.

- ensuring that the user can like or dislike an article.

[Delivers #164489935]

changes

changes
cop1fab pushed a commit that referenced this pull request Apr 17, 2019
feature(Likes & Dislikes): Allowing a user to like or dislike an article.

- ensuring that the user can like or dislike an article.

[Delivers #164489935]

changes

changes
cop1fab pushed a commit that referenced this pull request Apr 17, 2019
feature(Likes & Dislikes): Allowing a user to like or dislike an article.

- ensuring that the user can like or dislike an article.

[Delivers #164489935]

changes

changes
cop1fab pushed a commit that referenced this pull request Apr 18, 2019
feature(Likes & Dislikes): Allowing a user to like or dislike an article.

- ensuring that the user can like or dislike an article.

[Delivers #164489935]

changes

changes
cop1fab pushed a commit that referenced this pull request Apr 18, 2019
feature(Likes & Dislikes): Allowing a user to like or dislike an article.

- ensuring that the user can like or dislike an article.

[Delivers #164489935]

changes

changes
cop1fab pushed a commit that referenced this pull request Apr 23, 2019
feature(Likes & Dislikes): Allowing a user to like or dislike an article.

- ensuring that the user can like or dislike an article.

[Delivers #164489935]

changes

changes
cop1fab pushed a commit that referenced this pull request Apr 23, 2019
feature(Likes & Dislikes): Allowing a user to like or dislike an article.

- ensuring that the user can like or dislike an article.

[Delivers #164489935]

changes

changes
cop1fab pushed a commit that referenced this pull request Apr 23, 2019
feature(Likes & Dislikes): Allowing a user to like or dislike an article.

- ensuring that the user can like or dislike an article.

[Delivers #164489935]

changes

changes
cop1fab pushed a commit that referenced this pull request Apr 24, 2019
feature(Likes & Dislikes): Allowing a user to like or dislike an article.

- ensuring that the user can like or dislike an article.

[Delivers #164489935]

changes

changes
cop1fab pushed a commit that referenced this pull request Apr 24, 2019
feature(Likes & Dislikes): Allowing a user to like or dislike an article.

- ensuring that the user can like or dislike an article.

[Delivers #164489935]

changes

changes
cop1fab pushed a commit that referenced this pull request Apr 24, 2019
feature(Likes & Dislikes): Allowing a user to like or dislike an article.

- ensuring that the user can like or dislike an article.

[Delivers #164489935]

changes

changes
cop1fab pushed a commit that referenced this pull request May 2, 2019
feature(Likes & Dislikes): Allowing a user to like or dislike an article.

- ensuring that the user can like or dislike an article.

[Delivers #164489935]

changes

changes
cop1fab pushed a commit that referenced this pull request May 2, 2019
feature(Likes & Dislikes): Allowing a user to like or dislike an article.

- ensuring that the user can like or dislike an article.

[Delivers #164489935]

changes

changes
cop1fab pushed a commit that referenced this pull request May 3, 2019
feature(Likes & Dislikes): Allowing a user to like or dislike an article.

- ensuring that the user can like or dislike an article.

[Delivers #164489935]

changes

changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants