#169817866 : Implement social authentication with Google and Facebook #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jo-rdan
force-pushed
the
ft/169817866/social-auth
branch
3 times, most recently
from
6826bbb
to
4a004eb
Compare
jo-rdan
force-pushed
the
ft/169817866/social-auth
branch
2 times, most recently
from
4d42e1c
to
cffbf21
Compare
Jajabenit250
previously approved these changes
Dec 10, 2019
Jajabenit250
dismissed
their stale review
Just work on error and let me know when you are done
aanchirinah
suggested changes
Dec 10, 2019
jo-rdan
force-pushed
the
ft/169817866/social-auth
branch
from
cffbf21
to
8337398
Compare
jo-rdan
force-pushed
the
ft/169817866/social-auth
branch
from
8337398
to
a148b18
Compare
jo-rdan
force-pushed
the
ft/169817866/social-auth
branch
3 times, most recently
from
f324642
to
1062029
Compare
Jajabenit250
approved these changes
Dec 12, 2019
aanchirinah
suggested changes
Dec 12, 2019
jo-rdan
force-pushed
the
ft/169817866/social-auth
branch
3 times, most recently
from
0998ef2
to
2577ee0
Compare
jo-rdan
force-pushed
the
ft/169817866/social-auth
branch
from
2577ee0
to
ccc2a4d
Compare
- implement facebook authentication - implement google authentication - write unit tests [Delivers #169817866]
jo-rdan
force-pushed
the
ft/169817866/social-auth
branch
from
ccc2a4d
to
f5be79b
Compare
shemaeric1234
pushed a commit
that referenced
this pull request
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It implements the login with facebook and google
Description of Task to be completed?
How should this be manually tested?
npm startFor google
http://localhost:3000/api/v1/auth/googlein the browser and hit sendit should return 200 status code alongside the data and also sign the token to be able to access other routes of our app
For facebook
http://localhost:3000/api/v1/auth/facebookin the browser and hit sendit should return 200 status code alongside the data and also sign the token to be able to access other routes of our app
Any background context you want to provide?
What are the relevant pivotal tracker stories?
#169817866
Screenshots (if appropriate)
Google
Facebook
Database
