Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#169254678 Build out get all articles for a specific user #66

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

nshutijonathan
Copy link
Contributor

What does this PR do?

-It gets all articles for a specific user

Description of Task to be completed?

-logged in user should be able to get all the articles he published

How should this be manually tested?

  • Download or clone the tutorial project code from here, in your terminal then git checkout ft-user-get-only-all-his-article-169254678 , install all required NPM packages by running NPM install from the command line in the project root folder (where the package.json is located).

  • Start the API by running NPM start from the command line in the project root folder, you should see the message Server listening on port 8000. You can test the API directly using an application such as Postman or you can test it with one of the single pages in the browser.

  • to test authentication and authorization, add this to the header
    Key: :x-access-token,value:JWT TOKEN

Any background context you want to provide?

What are the relevant pivotal tracker stories?

https://www.pivotaltracker.com/story/show/169254678

Screenshots (if appropriate)

image

image

Questions:

@nshutijonathan nshutijonathan force-pushed the ft-user-get-only-all-his-article-169254678 branch from 0aff7ac to 8984b8f Compare October 21, 2019 11:46
@salviosage salviosage requested review from minega25, Anguandia, nkalyesubula and salviosage and removed request for Mnickii October 21, 2019 12:35
Anguandia
Anguandia previously approved these changes Oct 21, 2019
Copy link
Contributor

@Anguandia Anguandia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM doesn't break any build and serves the purpose. any defects shall be another iteration please go ahead and hasten the front-end. Good work

Copy link
Collaborator

@salviosage salviosage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tho u can shorten endpoint like articles/mine instead of articles /user/article

@nshutijonathan nshutijonathan force-pushed the ft-user-get-only-all-his-article-169254678 branch from 111588c to 56f37eb Compare October 21, 2019 18:53
@nshutijonathan
Copy link
Contributor Author

LGTM, tho u can shorten endpoint like articles/mine instead of articles /user/article

I worked on your feedback thank you

@salviosage salviosage self-requested a review October 22, 2019 07:52
Copy link
Contributor

@habinezadalvan habinezadalvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salviosage salviosage merged commit 9f82434 into develop Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants