#159403248 Increase coverage by 75% #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add tests for user profile modifications - modify a utility function - modify validate.js [Delivers #159403248]
Pull Request Test Coverage Report for Build 212
💛 - Coveralls |
klevamane
reviewed
Aug 1, 2018
| @@ -45,7 +45,7 @@ export default class ValidateUser { | |||
| static validatePassword(str) { | |||
| const passwordFormat = /((^[0-9]+[a-z]+)|(^[a-z]+[0-9]+))+[0-9a-z]+$/i; | |||
| if (!str || str.trim().length < 1) { | |||
| return { error: 'Password cannnot be empty' }; | |||
| return { error: 'Password cannot be empty' }; | |||
There was a problem hiding this comment.
Implement returning 'error' as stated in the readme.
There was a problem hiding this comment.
I believe this is a function I wrote. This return is from a helper method in this class and not from the json response. The Json response using this method returns errors in the right format.
klevamane
suggested changes
Aug 1, 2018
OKiMaureen
approved these changes
Aug 2, 2018
klevamane
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Increase coverage by 75%
Description of Task to be completed?
How should this be manually tested?
cdinto the directorycp .env.sample .envnpm installnpm run migratenpm testAny background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#159403248
Screenshots (if appropriate)
N/A