#166816075 user notification opt-in/opt-out #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devPinheiro
requested review from
dharmykoya and
tunedev
and removed request for
dharmykoya
devPinheiro
force-pushed
the
ft-notification-opt-in-out-166816075
branch
from
1b35ee5
to
071bf19
Compare
dharmykoya
approved these changes
Sep 1, 2019
| @@ -61,7 +61,7 @@ describe('<ProfileNavbar />', () => { | |||
| </BrowserRouter> | |||
| </Provider> | |||
| ); | |||
| const editButton = profileNav.find('.btn-navbar').simulate('click'); | |||
| // const editButton = profileNav.find('.btn-navbar').simulate('click'); | |||
There was a problem hiding this comment.
please do remove this commented code
| } | ||
| } | ||
| }; | ||
| // const props = { |
There was a problem hiding this comment.
remove this commented codes too... thanks
| .find('.article-body StarRatingComponent label') | ||
| .at(2) | ||
| .simulate('click'); | ||
| // const instance = readArticle.instance(); |
devPinheiro
force-pushed
the
ft-notification-opt-in-out-166816075
branch
from
071bf19
to
b5ce475
Compare
update edit profile component write tests [Finishes #166816075]
devPinheiro
force-pushed
the
ft-notification-opt-in-out-166816075
branch
from
b5ce475
to
d511571
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
After cloning the repo, cd into the root folder
Install all necessary dependencies by running
npm installLaunch the node server with
npm run devUsing a web browser visit the link below:
localhost:8080/To run local tests using Jest
npm testAny background context you want to provide?
What are the relevant pivotal tracker stories?
[#166816075] (https://www.pivotaltracker.com/story/show/166816075)