-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
167727645 Show Profile Information #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!!
User has option to display profile information when making a trip request. [Starts #167727645]
962a76e
to
6d28853
Compare
message: 'Update successful', | ||
rememberDetails: update.get().rememberDetails | ||
}, 200 | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected newline before ')' function-paren-newline
); | ||
} | ||
|
||
return HelperMethods.requestSuccessful( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected newline after '(' function-paren-newline
success: false, | ||
message: 'User not found' | ||
}, 404 | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected newline before ')' function-paren-newline
); | ||
|
||
if (!update) { | ||
return HelperMethods.clientError( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected newline after '(' function-paren-newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does this PR do?
Enable user toggle option to display profile information when he/she makes a trip request.
Description of Task to be completed?
PATCH api/v1/remember_details
to toggle 'rememberDetails' field of user.How should this be manually tested?
cd
into the project directoryyarn install
to install the project's dependencyyarn test
to test the appWhat are the relevant pivotal tracker stories?
#167727645