167727645 Show Profile Information #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChidozieGabriel
added
the
Ready-for-review
User has option to display profile information when making a trip request. [Starts #167727645]
Daymorelah
force-pushed
the
ft-show-profile-info-167727645
branch
from
962a76e
to
6d28853
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| message: 'Update successful', | ||
| rememberDetails: update.get().rememberDetails | ||
| }, 200 | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
| ); | ||
| } | ||
|
|
||
| return HelperMethods.requestSuccessful( |
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
| success: false, | ||
| message: 'User not found' | ||
| }, 404 | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
| ); | ||
|
|
||
| if (!update) { | ||
| return HelperMethods.clientError( |
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable user toggle option to display profile information when he/she makes a trip request.
Description of Task to be completed?
PATCH api/v1/remember_detailsto toggle 'rememberDetails' field of user.How should this be manually tested?
cdinto the project directoryyarn installto install the project's dependencyyarn testto test the appWhat are the relevant pivotal tracker stories?
#167727645