-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#168049961 Users should see a toast for new notifiications #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
819c148
to
e131b64
Compare
e131b64
to
d51a355
Compare
d51a355
to
4814b1a
Compare
4814b1a
to
af425b1
Compare
af425b1
to
95e1627
Compare
95e1627
to
20234b6
Compare
20234b6
to
dbdaccb
Compare
dbdaccb
to
ecc0baa
Compare
ecc0baa
to
141a02a
Compare
mucyomiller
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- fix notification number show issue for mark one as read - add dockerfile - set up live notifications for apdate, create and approve/reject for relelvant users - set up and filter real time comment notifications [Finishes #168049961]
141a02a
to
09b7ad3
Compare
gik-hub
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#168049961
Screenshots (if appropriate)
Questions:
N/A