Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#168049961 Users should see a toast for new notifiications #34

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

didasmbalanya
Copy link
Contributor

What does this PR do?

  • Set up event listeners from the server

Description of Task to be completed?

  • Add event listeners on the notification component

How should this be manually tested?

  • Pass an event which from the backend eg creating a new request
  • Be logged as the manager of the user creating the request on another tab
  • You will see a real-time notification as soon as the user creates the toast

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#168049961

Screenshots (if appropriate)

Questions:

N/A

@gik-hub gik-hub temporarily deployed to technites-bn-frontend-st-pr-34 November 29, 2019 15:15 Inactive
@didasmbalanya didasmbalanya temporarily deployed to technites-bn-frontend-st-pr-34 December 2, 2019 11:11 Inactive
@didasmbalanya didasmbalanya temporarily deployed to technites-bn-frontend-st-pr-34 December 3, 2019 16:23 Inactive
@didasmbalanya didasmbalanya had a problem deploying to technites-bn-frontend-st-pr-34 December 3, 2019 16:29 Failure
@didasmbalanya didasmbalanya had a problem deploying to technites-bn-frontend-st-pr-34 December 3, 2019 16:36 Failure
@didasmbalanya didasmbalanya had a problem deploying to technites-bn-frontend-st-pr-34 December 3, 2019 16:38 Failure
@didasmbalanya didasmbalanya temporarily deployed to technites-bn-frontend-st-pr-34 December 4, 2019 14:52 Inactive
@didasmbalanya didasmbalanya temporarily deployed to technites-bn-frontend-st-pr-34 December 4, 2019 14:59 Inactive
@didasmbalanya didasmbalanya temporarily deployed to technites-bn-frontend-st-pr-34 December 5, 2019 08:13 Inactive
@didasmbalanya didasmbalanya temporarily deployed to technites-bn-frontend-st-pr-34 December 5, 2019 08:43 Inactive
Copy link
Contributor

@mucyomiller mucyomiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- fix notification number show issue for  mark one as read
- add dockerfile
- set up live notifications for apdate, create and approve/reject for relelvant users
- set up and filter real time comment notifications
[Finishes #168049961]
Copy link
Contributor

@gik-hub gik-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@gik-hub gik-hub merged commit 034531d into develop Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants