#166241006 - Listing the Users profile #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deschantkn
previously requested changes
Jun 19, 2019
src/api/routes/userRouter.js
Outdated
|
|
||
| const userRouter = Router(); | ||
| const { updateProfile } = ProfilesController; | ||
| const { verifyToken } = Auth; | ||
|
|
||
| userRouter.put('/', verifyToken, validateBody('updateUser'), updateProfile); | ||
| userRouter.put('/', verifyToken, check.profileOwner, validateBody('updateUser'), updateProfile); |
There was a problem hiding this comment.
This middleware is not necessary as token verification ensures the user exists. What can be done is to update the 404 status code in the controller to 403.
src/middleware/checkOwner.js
Outdated
| */ | ||
| static async profileOwner(req, res, next) { | ||
| const { id, username } = req.user; | ||
| const userFound = await User.findOne({ where: { id, username } }); |
There was a problem hiding this comment.
How does this verify profile ownership? It is just repeating what token verification does. You should remove it.
UhiriweAudace
force-pushed
the
ft-listing-user-profiles-166241006
branch
3 times, most recently
from
5e78c20
to
bc647fa
Compare
eliemugenzi
previously approved these changes
Jun 19, 2019
UhiriweAudace
force-pushed
the
ft-listing-user-profiles-166241006
branch
2 times, most recently
from
99c4189
to
7c659fc
Compare
eliemugenzi
reviewed
Jun 20, 2019
src/api/controllers/profiles.js
Outdated
| */ | ||
| static async getAllProfile(req, res) { | ||
| const fetchedProfile = await User.findAll({ attributes: ['username', 'firstName', 'lastName', 'bio', 'image'] }); | ||
| if (!fetchedProfile[0]) return res.status(404).send({ error: 'No Users Profiles found!' }); |
There was a problem hiding this comment.
This is not a client error, it should not be 404.
There was a problem hiding this comment.
@eliemugenzi Thanks! i'm going to fix it
UhiriweAudace
force-pushed
the
ft-listing-user-profiles-166241006
branch
5 times, most recently
from
96ee92d
to
70ea267
Compare
eliemugenzi
approved these changes
Jun 20, 2019
EmyRukundo
approved these changes
Jun 20, 2019
UhiriweAudace
force-pushed
the
ft-listing-user-profiles-166241006
branch
from
70ea267
to
115b74f
Compare
UhiriweAudace
force-pushed
the
ft-listing-user-profiles-166241006
branch
from
115b74f
to
de26f34
Compare
Quantum-35
approved these changes
Jun 21, 2019
UhiriweAudace
added
Needs Merge
Diama1
pushed a commit
that referenced
this pull request
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this PR, I implemented the endpoints that help any user/client to be able to view a list of all user's profile
Description of Task to be completed?
Having the following Endpoints working:
GET /api/profilesHow should this be manually tested?
cd tesla-ahyarn installoryarnsequelize db:migratefor this command make sure that thesequelize-clipackage is installed globallyyarn devyarn test:localAny background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#166241006
Screenshots (if appropriate)
N/A
Questions:
Before Code - Audace Uhiriwe
https://docs.google.com/document/d/1bWYaHMgb3SyKN9QfmD9KbeX-WeDGHjplg66l8wOdYso/edit?usp=sharing