Save read time on article creation and update #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
src/helpers/articlesHelper.js
Outdated
| }); | ||
| console.log(readTime(body)); |
There was a problem hiding this comment.
Unexpected console statement no-console
eliemugenzi
force-pushed
the
ch-readtime-fix
branch
4 times, most recently
from
b0e5a8c
to
de97dda
Compare
mifeille
approved these changes
Jun 21, 2019
eliemugenzi
force-pushed
the
ch-readtime-fix
branch
from
de97dda
to
a33ca19
Compare
Diama1
approved these changes
Jun 21, 2019
EmyRukundo
approved these changes
Jun 21, 2019
eliemugenzi
force-pushed
the
ch-readtime-fix
branch
2 times, most recently
from
dac4c68
to
ad525fa
Compare
eliemugenzi
force-pushed
the
ch-readtime-fix
branch
from
ad525fa
to
36da6f6
Compare
Quantum-35
approved these changes
Jun 21, 2019
Diama1
pushed a commit
that referenced
this pull request
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what does this PR do?
Description of a task to be completed
How should this be manually tested?
yarn installyarn migrateyarn dev/api/articles, and use POST request to create a new article./api/articles/{slug}and use PUT request to update an article./api/articles/{slug}using GET request, the response comes with article's read time.