#166241013 Implement articles reading statistics #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mifeille
force-pushed
the
ft-article-reading-stats-166241013
branch
2 times, most recently
from
35a35a1
to
210771e
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
src/sequelize/models/share.js
Outdated
| // associations can be defined here | ||
| }; | ||
| return Share; | ||
| }; |
There was a problem hiding this comment.
Newline required at end of file but not found eol-last
src/sequelize/models/share.js
Outdated
| slug: DataTypes.STRING, | ||
| provider: DataTypes.STRING | ||
| }, {}); | ||
| Share.associate = function(models) { |
There was a problem hiding this comment.
'models' is defined but never used no-unused-vars
Missing space before function parentheses space-before-function-paren
Unexpected unnamed function func-names
src/sequelize/models/share.js
Outdated
| @@ -0,0 +1,12 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
'use strict' is unnecessary inside of modules strict
Expected newline after "use strict" directive lines-around-directive
mifeille
force-pushed
the
ft-article-reading-stats-166241013
branch
2 times, most recently
from
bc9e8fb
to
0a40da1
Compare
deschantkn
approved these changes
Jul 2, 2019
EmyRukundo
approved these changes
Jul 2, 2019
mifeille
force-pushed
the
ft-article-reading-stats-166241013
branch
from
0a40da1
to
80f9142
Compare
eliemugenzi
approved these changes
Jul 2, 2019
mifeille
force-pushed
the
ft-article-reading-stats-166241013
branch
2 times, most recently
from
cf8c750
to
4b7240d
Compare
mifeille
force-pushed
the
ft-article-reading-stats-166241013
branch
from
4b7240d
to
e214a19
Compare
Diama1
pushed a commit
that referenced
this pull request
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables users to see articles readings statistics
Description of Task to be completed?
Have the following endpoints working :
GET /api/articles/:slug/comments/count
GET /api/articles/:slug/views
GET /api/articles/:slug/shares/facebook
GET /api/articles/:slug/shares/twitter
GET /api/articles/:slug/shares/email
GET /api/articles/:slug/shares
How should this be manually tested?
Clone the repo, cd into it and RUN yarn install to install all the dependencies,
• Run the migration
sequelize db:migrate,• Run the seeds
sequelize db:seed:all,• Run
yarn testfor tests,• then Run
yarn devto start the server.Use postman to test if the endpoints are working.
What are the relevant pivotal tracker stories?
#166241013
Use Case document
https://docs.google.com/document/d/1GsSGnNb99l11xMxwf9AoIBx1RMyn2raz9Uxpsh6KrYs/edit?usp=sharing