#166979034 Enable users to chat #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| } | ||
| }), | ||
| down: queryInterface => queryInterface.dropTable('Chats') | ||
| }; |
There was a problem hiding this comment.
Newline required at end of file but not found eol-last
rukundoeric
force-pushed
the
ft-user-chat-166979034
branch
2 times, most recently
from
eed75a5
to
c6d5110
Compare
test/chat.test.js
Outdated
| password: 'Superadmin1' | ||
| }) | ||
| .end((err, res) => { | ||
| console.log(res.body); |
There was a problem hiding this comment.
Unexpected console statement no-console
rukundoeric
force-pushed
the
ft-user-chat-166979034
branch
from
c6d5110
to
677d56f
Compare
test/chat.test.js
Outdated
| expect(res.body).to.be.an('object'); | ||
| const { token } = res.body.data; | ||
| userToken = token; | ||
| console.log(res.body); |
There was a problem hiding this comment.
Unexpected console statement no-console
rukundoeric
force-pushed
the
ft-user-chat-166979034
branch
2 times, most recently
from
93bec14
to
b9ec308
Compare
rukundoeric
force-pushed
the
ft-user-chat-166979034
branch
3 times, most recently
from
7c78d34
to
cbab7f6
Compare
eliemugenzi
force-pushed
the
ft-user-chat-166979034
branch
3 times, most recently
from
52f41f1
to
e7c6780
Compare
EmyRukundo
approved these changes
Jul 19, 2019
|
you have some conflicts, rebase!! |
rukundoeric
force-pushed
the
ft-user-chat-166979034
branch
from
e7c6780
to
5dd6c3c
Compare
src/helpers/SocketIO.js
Outdated
| }); | ||
| return io; | ||
| }; | ||
|
|
||
| export default SocketIO; | ||
| export default SocketIO; |
There was a problem hiding this comment.
Newline required at end of file but not found eol-last
rukundoeric
force-pushed
the
ft-user-chat-166979034
branch
from
5dd6c3c
to
65088a6
Compare
deschantkn
approved these changes
Jul 19, 2019
mifeille
approved these changes
Jul 19, 2019
eliemugenzi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
GET /api/chats/usersGET /api/chats/:usernameHow should this be manually tested?
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#166979034
Use case documentation
Chat user case documentaion
Screenshots (if appropriate)
Questions:
N/A