-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#166979034 Enable users to chat #79
Conversation
} | ||
}), | ||
down: queryInterface => queryInterface.dropTable('Chats') | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline required at end of file but not found eol-last
eed75a5
to
c6d5110
Compare
test/chat.test.js
Outdated
password: 'Superadmin1' | ||
}) | ||
.end((err, res) => { | ||
console.log(res.body); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected console statement no-console
c6d5110
to
677d56f
Compare
test/chat.test.js
Outdated
expect(res.body).to.be.an('object'); | ||
const { token } = res.body.data; | ||
userToken = token; | ||
console.log(res.body); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected console statement no-console
93bec14
to
b9ec308
Compare
7c78d34
to
cbab7f6
Compare
52f41f1
to
e7c6780
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work guys!
you have some conflicts, rebase!! |
e7c6780
to
5dd6c3c
Compare
src/helpers/SocketIO.js
Outdated
}); | ||
return io; | ||
}; | ||
|
||
export default SocketIO; | ||
export default SocketIO; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline required at end of file but not found eol-last
5dd6c3c
to
65088a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Description of Task to be completed?
GET /api/chats/users
GET /api/chats/:username
How should this be manually tested?
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#166979034
Use case documentation
Chat user case documentaion
Screenshots (if appropriate)
Questions:
N/A