#159987721 List and update Users functionality #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users could previously update other users' profile. To prevent this we simply check the user in the current session and compare it with the record being updated. - Include relevant tests
Pull Request Test Coverage Report for Build 256
💛 - Coveralls |
d-beloved
suggested changes
Sep 10, 2018
| error.status = 401; | ||
| return next(error); | ||
| } | ||
|
|
||
| if (!isValid) { | ||
| return res.status(400).json({ errors }); | ||
| } |
d-beloved
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
prevent user from updating other users profiles
Description of Task to be completed?
Users could previously update other users' profile. To prevent this
we simply check the user in the current session and compare it with the
record being updated.
How should this be manually tested?
Run
npm run migrateRun
npm run start:devsend a
PUTrequest toapi/users/<userId>to update user profileWhat are the relevant pivotal tracker stories?
#159987721